Uh oh!
There was an error while loading. Please reload this page.
dockerfile: create stub file with frontmatter - #15165
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
actually not so great atm as we have to fetch remote reference in the same folder so we can include it with liquid template func |
8534df5 to
c86c00eCompareUh oh!
There was an error while loading. Please reload this page.
c86c00e to
38622ffCompare| repo: crazy-max/buildkit | ||
| ref: docs-ref-move-frontmatter |
thaJeztah
commented
Jul 20, 2022
I'm a bit confused though; for other includes, we use the |
thaJeztah
commented
Jul 20, 2022
Or is that because of relative links to markdown files? |
Hum indeed it might work with the |
Uh oh!
There was an error while loading. Please reload this page.
38622ff to
9262650Compare| - file: "frontend/dockerfile/docs/reference.md" | ||
| line_start: 2 | ||
| line_end: -1 |
There was a problem hiding this comment.
@thaJeztah As discussed, removed the github_content liquid tag plugin and enhance our fetch_remote plugin to be able to specify line_start and line_end
There was a problem hiding this comment.
Argh edit_url and issue_url is lost then 😣
There was a problem hiding this comment.
Ok managed to fix edit_url and issue_url inclusion by grabbing the one available in site default scope. I have created a dedicated liquid tag named include_remote that does pretty much the same job as include except it also handles <line_start>, <line_end> and creates the right edit_url and issue_url.
LGTY @thaJeztah ?
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
9262650 to
04ae02bCompare| - repo: "https://github.com/crazy-max/buildkit" | ||
| default_branch: "master" | ||
| ref: "master" | ||
| ref: "docs-ref-move-frontmatter" |
There was a problem hiding this comment.
use my fork while waiting for moby/buildkit#2970 to be merged
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM after switching to upstream once moby/buildkit#2970 is merged
04ae02b to
57144bdCompare
needs moby/buildkit#2970
as discussed, it's better to have the frontmatter section here instead of the buildkit repo.
needs to fetch remote reference in the same folder otherwise we can't include it in the stub file. will be fixed anyway when we are going to move to the new location in #15110