Uh oh!
There was an error while loading. Please reload this page.
move resources to assets folder - #15246
Conversation
✅ Deploy Preview for docsdocker ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
5088efa to
273442aCompared041fad to
8f17ac8ComparethaJeztah
commented
Sep 2, 2022
heads up that this one may require some changes in https://github.com/docker/docker.github.io/pull/15473/files#r956760218 |
thaJeztah
left a comment
There was a problem hiding this comment.
Looks good! Had one question, perhaps you know the answer to that one
| Including the vulnerability scanning options into the Docker platform extends the existing, familiar process of vulnerability detection, and allows for remediation of vulnerabilities earlier in the development process. The process of simple and continuous checks, for example, by checking images in the background using [Snyk Advisor](https://snyk.io/advisor/docker){:target="_blank" rel="noopener" class="_"}, can lead to fewer vulnerabilities checked into Docker Hub. This can result in a shorter CI cycle and a more reliable deployment into production. | ||
| {:width="700px"} | ||
| {:width="700px"} |
There was a problem hiding this comment.
I'm confused; wow did this work? Because the old URL is a 404; https://docs.docker.com/images/images/docker-scan-cli.png, but the rendered page somehow uses the correct URL?
There was a problem hiding this comment.
I think it's not 404 because of the canonical url of this page:
<link rel="canonical" href="https://docs.docker.com/develop/scan-images/" />
There was a problem hiding this comment.
Hmm.. not sure; if that was a base href, I could see that, but canonical shouldn't mean (afaik) anything other than "there's multiple pages with similar content; this URL is the canonical one".
No idea; odd
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
perhaps merge after the weekend?
crazy-max
commented
Sep 2, 2022
Yes fine to me |
crazy-max
commented
Sep 5, 2022
@thaJeztah Rebased with master, PTAL |
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
follow-up #15223 (comment)
Font Awesome library has been moved to
assetsfolder in #15223 because accessing the resources from their css moved the fonts to a webfonts folder which is relative to their css.To keep things consistent with resources in this repo, I moved them to the assets folder as well (see https://github.com/crazy-max/docker.github.io/tree/move-assets/assets). It will make resources easier to discover and track and also avoid to bloat root dir of the repository. It also makes more sense to have the resources dedicated to the libraries in their respective folders so you know which css is linked to which font (same for javascript).
As discussed with @thaJeztah, we should also take a look in a follow-up to reorganize the images in this repo as some of them are not used anymore or are duplicated in other folders.