Skip to content

Document legacy build vs BuildKit differences - #15477

Merged
dvdksn merged 2 commits into
docker:masterfrom
andreisilviudragnea:moby-buildkit-diffs
Oct 22, 2022
Merged

Document legacy build vs BuildKit differences#15477
dvdksn merged 2 commits into
docker:masterfrom
andreisilviudragnea:moby-buildkit-diffs

Conversation

@andreisilviudragnea

@andreisilviudragneaandreisilviudragnea commented Aug 24, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

I documented how legacy engine executes all stages of a multi-stage Dockerfile from the beginning of the Dockerfile up to the target stage, even if target stage does not depend on some intermediate stages. When BuildKit is enabled, this (possible bug) does not happen and only transitive dependency stages of the target stage get executed.

I also documented that BuildKit is not enabled by default on all platforms (it is on macOS, but not on Linux) and that multi-stage builds should always be executed with BuildKit enabled in order to avoid the problem described above.

Related issues

Fixes#12231

@netlify

netlifyBot commented Aug 24, 2022

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

Built without sensitive environment variables

NameLink
🔨 Latest commit06c9675
🔍 Latest deploy loghttps://app.netlify.com/sites/docsdocker/deploys/63065fffb8281b00094ca9cf
😎 Deploy Previewhttps://deploy-preview-15477--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@craig-osterhoutcraig-osterhout added the area/build Relates to Dockerfiles or docker build command label Aug 24, 2022
@andreisilviudragnea

andreisilviudragnea commented Sep 7, 2022

Copy link
Copy Markdown
ContributorAuthor

@craig-osterhout When will this be reviewed and merged?

@usha-mandya

usha-mandya commented Oct 18, 2022

Copy link
Copy Markdown
Member

@andreisilviudragnea Could you rebase the PR?

@netlify

netlifyBot commented Oct 20, 2022•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

NameLink
🔨 Latest commit017cc33
🔍 Latest deploy loghttps://app.netlify.com/sites/docsdocker/deploys/6353e6b993c6d70008987367
😎 Deploy Previewhttps://deploy-preview-15477--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@andreisilviudragnea

andreisilviudragnea commented Oct 20, 2022

Copy link
Copy Markdown
ContributorAuthor

@usha-mandya Done.

@usha-mandya

usha-mandya commented Oct 20, 2022

Copy link
Copy Markdown
Member

Thank you @andreisilviudragnea. One of our team members will take a look and get back to you.

dvdksn
dvdksn requested changes Oct 21, 2022
View reviewed changes

@dvdksndvdksn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think saying "moby vs buildkit" is confusing, in part since buildkit is also a moby project 😅 I think I would prefer if we could refer to it as "legacy vs buildkit", as we do on this page

Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
Comment threadbuild/building/multi-stage.md Outdated
dvdksn
dvdksn reviewed Oct 21, 2022
View reviewed changes
Comment threadbuild/building/multi-stage.md Outdated
@andreisilviudragnea
Document Moby vs BuildKit differences
49059b9
@andreisilviudragnea@dvdksn
Apply suggestions from code review
017cc33
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@andreisilviudragneaandreisilviudragnea changed the title Document Moby vs BuildKit differencesDocument legacy build vs BuildKit differencesOct 22, 2022
@andreisilviudragnea
andreisilviudragnea requested review from dvdksn and removed request for crazy-max, jedevc and usha-mandyaOctober 22, 2022 12:53
dvdksn
dvdksn approved these changes Oct 22, 2022
View reviewed changes

@dvdksndvdksn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks a lot @andreisilviudragnea

@dvdksn
dvdksn enabled auto-merge (squash) October 22, 2022 18:01
@dvdksn
dvdksn merged commit 278f595 into docker:masterOct 22, 2022
@andreisilviudragnea
andreisilviudragnea deleted the moby-buildkit-diffs branch October 23, 2022 20:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvdksndvdksndvdksn approved these changes
+1 more reviewer
@jedevcjedevcjedevc left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/buildRelates to Dockerfiles or docker build command

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Recommend Buildkit for using multi-stage builds

5 participants

@andreisilviudragnea@usha-mandya@jedevc@dvdksn@craig-osterhout