Uh oh!
There was an error while loading. Please reload this page.
doc review: update ubuntu (and debian) installlation guides - #15902
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| > | ||
| > ```console | ||
| > $ curl -fsSL https://get.docker.com -o get-docker.sh | ||
| > $ DRY_RUN=1 sh ./get-docker.sh |
There was a problem hiding this comment.
Should the DRY_RUN example include sudo? It is required and shown in non-dry-run call below.
| $ sudo docker run hello-world | ||
| ``` | ||
| ```console | ||
| $ sudo service docker start |
There was a problem hiding this comment.
docker starts automatically on Debian
| `hello-world` image: | ||
| ```console | ||
| $ sudo service docker start |
There was a problem hiding this comment.
docker starts automatically on Ubuntu
sam-thibault
left a comment
There was a problem hiding this comment.
Thanks for these updates! Just a couple small notes from me.
8c3ecc5 to
9e0c6f3Compare
aevesdocker
left a comment
There was a problem hiding this comment.
Soooo much clearer and efficient. Just some tiny tweaks/comments
I also wonder, and this is certainly beyond the scope of this PR, if it is worth pulling out all the 'Uninstall' sections into one page? Similar to how it is in Desktop. It's never made sense to me to include the uninstall content on the install pages.
| - In testing and development environments, some users choose to use automated | ||
| [convenience scripts](#install-using-the-convenience-script) to install Docker. | ||
| This is currently the only approach for Raspbian. | ||
| - [Install it manually](#install-from-a-package) and manage upgrades completely |
There was a problem hiding this comment.
I know this was written before you edited this page, but wonder if we can take this opportunity to remove 'completely'?
| - [Install it manually](#install-from-a-package) and manage upgrades completely | ||
| manually. | ||
| - Using a [convenience scripts](#install-using-the-convenience-script) (only |
| Docker from the repository. | ||
| > **Raspbian users cannot use this method!** | ||
| > **Raspbian users can't use this method!** |
There was a problem hiding this comment.
Again, I know this was here already, but can we remove the '!' ?
| 3. Verify that Docker Engine is installed correctly by running the `hello-world` | ||
| image. | ||
| 3. Verify that the Docker Engine installation was successful by running the |
There was a problem hiding this comment.
| 3. Verify that the Docker Engine installation was successful by running the | |
| 3. Verify that the Docker Engine installation is successful by running the |
| The Docker daemon starts automatically. | ||
| 6. Verify that the Docker Engine installation was successful by running the |
There was a problem hiding this comment.
| 6. Verify that the Docker Engine installation was successful by running the | |
| 6. Verify that the Docker Engine installation is successful by running the |
| 3. Verify that Docker Engine is installed correctly by running the `hello-world` | ||
| image. | ||
| 3. Verify that the Docker Engine installation was successful by running the |
There was a problem hiding this comment.
| 3. Verify that the Docker Engine installation was successful by running the | |
| 3. Verify that the Docker Engine installation is successful by running the |
dvdksn
commented
Oct 21, 2022
Yes, totally. Let me make this a follow-up PR to weed out the uninstall steps (and maybe update too) from here. Needs to take all OS/distro instructions into consideration. |
Documentation review of the Ubuntu installation guide.
This is a part of the effort of keeping our most popular content up to date and useful. The Ubuntu installation page is in the list of our top 20 most visited pages.
Also updating the corresponding Debian page as a result of these two being near-identical.