Skip to content

Update debian.md - #16654

Merged
thaJeztah merged 2 commits into
docker:mainfrom
ArnoSen:ArnoSen-patch-debian-install
Feb 7, 2023
Merged

Update debian.md#16654
thaJeztah merged 2 commits into
docker:mainfrom
ArnoSen:ArnoSen-patch-debian-install

Conversation

@ArnoSen

@ArnoSenArnoSen commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

Set correct filemask for /etc/apt/keyrings . If this is not 0755, the keys in the directory cannot be used.

Proposed changes

Related issues (optional)

@ArnoSen
Update debian.md
86f0823
Set correct filemask for `/etc/apt/keyrings` . If this is not 0755, the keys in the directory cannot be used.
@ArnoSen
ArnoSen requested a review from dvdksn as a code ownerFebruary 2, 2023 11:24
@netlify

netlifyBot commented Feb 2, 2023•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

NameLink
🔨 Latest commit4cea931
🔍 Latest deploy loghttps://app.netlify.com/sites/docsdocker/deploys/63e25c02c574450008dd6718
😎 Deploy Previewhttps://deploy-preview-16654--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@craig-osterhoutcraig-osterhout added area/engine Issue affects Docker engine/daemon area/install Relates to installing a product labels Feb 6, 2023
@ArnoSen

ArnoSen commented Feb 7, 2023

Copy link
Copy Markdown
ContributorAuthor

Closes #16626
Closes #16362

@dvdksn

dvdksn commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

@vvoland could you ptal? thanks

vvoland
vvoland previously approved these changes Feb 7, 2023
View reviewed changes

@vvolandvvoland left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; permissions applied by mkdir are dependent on the umask value, which in some cases may be different from 0022.

This is also conformant with Debian suggestions:

In releases older than Debian 12 and Ubuntu 22.04, /etc/apt/keyrings does not exist by default. It SHOULD be created with permissions 0755 if it is needed and does not already exist.
(source: https://wiki.debian.org/DebianRepository/UseThirdParty)

thaJeztah
thaJeztah previously approved these changes Feb 7, 2023
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left a suggestion; we can probably merge that suggestion and squash the commits 👍

Comment threadengine/install/debian.md Outdated
@thaJeztah
thaJeztah dismissed stale reviews from vvoland and themself via 4cea931February 7, 2023 14:11
thaJeztah
thaJeztah approved these changes Feb 7, 2023
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'll squash and merge 👍

@thaJeztah
thaJeztah merged commit 6d8b081 into docker:mainFeb 7, 2023
@thaJeztahthaJeztah mentioned this pull request Feb 7, 2023
Merged
@thaJeztahthaJeztah mentioned this pull request Apr 8, 2023
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request Jul 14, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztahthaJeztahthaJeztah approved these changes
@vvolandvvolandvvoland left review comments
@dvdksndvdksnAwaiting requested review from dvdksn

Assignees

No one assigned

Labels

area/engineIssue affects Docker engine/daemonarea/installRelates to installing a product

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ArnoSen@dvdksn@thaJeztah@vvoland@craig-osterhout