Uh oh!
There was an error while loading. Please reload this page.
ci: replace htmlproofer with wjdp/htmltest - #17096
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
thaJeztah
commented
Apr 12, 2023
I'm curious now what we used before |
thaJeztah
commented
Apr 12, 2023
Oh! never mind, looks like it was htmlproofer as well, but as a separate check; #13514 |
dvdksn
commented
Apr 12, 2023
the test works, it's failing because of some file in an upstream compose repo has a bad link |
crazy-max
commented
Apr 12, 2023
@docker/compose-maintainers https://github.com/docker/docs/actions/runs/4678750123/jobs/8287857444?pr=17096#step:5:60 |
dvdksn
commented
Apr 12, 2023
I will add |
thaJeztah
commented
Apr 12, 2023
Oh! Those are the fun ones. Does it allow for "warning" <--> "error" for certain files (that are maintained elsewhere?) Or at least until we have a proper baseline? (worst case, we could push some temporary commits to manually patch things if they are "vendored" in this repository) |
dvdksn
commented
Apr 12, 2023
Unfortunately they are not vendored, but pulled during build :( so I think the pragmatic way fwd is to ignore these files until they are fixed. Buildx uses a docs validation workflow that performs the linting on changes in the upstream. |
crazy-max
commented
Apr 12, 2023
Yeah maybe compose should have this kind of validation too |
Signed-off-by: David Karlsson <david.karlsson@docker.com>
Signed-off-by: David Karlsson <david.karlsson@docker.com>
Signed-off-by: David Karlsson <david.karlsson@docker.com>
milas
commented
Apr 13, 2023
Is this the workflow we should copy for Compose spec? https://github.com/docker/buildx/blob/master/.github/workflows/docs-upstream.yml |
crazy-max
commented
Apr 13, 2023
@milas Yes |
Signed-off-by: David Karlsson david.karlsson@docker.com
Proposed changes
This replaces the Ruby-based htmlproofer with htmltest
This tool runs faster and seems to provide additional checking capabilities and more configuration opts.
(Most of which I have disabled for now, since we're violating them 🙈)
Related issues (optional)