Skip to content

desktop: refresh containerd examples - #17106

Merged
dvdksn merged 2 commits into
docker:mainfrom
dvdksn:desktop/refresh-c8d
Apr 27, 2023
Merged

desktop: refresh containerd examples#17106
dvdksn merged 2 commits into
docker:mainfrom
dvdksn:desktop/refresh-c8d

Conversation

@dvdksn

@dvdksndvdksn commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

Signed-off-by: David Karlsson david.karlsson@docker.com

Proposed changes

This refreshes the containerd examples.

This removes some docker info and docker run examples, which IMO don't add a lot of useful information.

I also rewrote the section no multi-platform builds in an attempt to improve it.

Related issues (optional)

This update was actually triggered by the fact that we should remove the Registry: field from docker info.

See: docker/cli#4204

@netlify

netlifyBot commented Apr 13, 2023•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

NameLink
🔨 Latest commit43de7a9
🔍 Latest deploy loghttps://app.netlify.com/sites/docsdocker/deploys/64463e2546b86e0008ea6419
😎 Deploy Previewhttps://deploy-preview-17106--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dvdksn

dvdksn commented Apr 13, 2023

Copy link
Copy Markdown
ContributorAuthor

@thaJeztah@rumpl ptal

thaJeztah
thaJeztah reviewed Apr 13, 2023
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on removing some of that content (agreed that it's not very useful).

Left some comments / thoughts on what to show on some of the output

Comment threaddesktop/containerd/index.md Outdated
Comment threaddesktop/containerd/index.md Outdated
Comment threaddesktop/containerd/index.md Outdated
thaJeztah
thaJeztah reviewed Apr 13, 2023
View reviewed changes
Comment threaddesktop/images/containerd_feature_nginx.png
@dvdksn
dvdksnforce-pushed the desktop/refresh-c8d branch from d787709 to cec4f0cCompareApril 14, 2023 08:45
@dvdksn
desktop: refresh containerd examples
7a1773a
Signed-off-by: David Karlsson <david.karlsson@docker.com>
@dvdksn
dvdksnforce-pushed the desktop/refresh-c8d branch from cec4f0c to 7a1773aCompareApril 14, 2023 08:47
@dvdksn
dvdksn requested a review from thaJeztahApril 14, 2023 13:48
@dvdksndvdksn mentioned this pull request Apr 14, 2023
Merged
@dvdksn
desktop: add a description for the containerd image store feature
43de7a9
Signed-off-by: David Karlsson <david.karlsson@docker.com>
@dvdksn
dvdksnforce-pushed the desktop/refresh-c8d branch from c72d36a to 43de7a9CompareApril 24, 2023 08:30
rumpl
rumpl reviewed Apr 24, 2023
View reviewed changes
Comment threaddesktop/containerd/index.md

Docker Engine already uses containerd for container lifecycle management, which
includes creating, starting, and stopping containers. This page describes the
next step of containerd integration for Docker Engine: the image store.

@rumplrumplApr 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove the whole "image store" wording and say : image management?

@dvdksndvdksnApr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to keep the term "image store" for now, since it also appears in the Docker Desktop settings

image

NiklasBr
NiklasBr reviewed Apr 24, 2023
View reviewed changes
Comment threaddesktop/containerd/index.md
thaJeztah
thaJeztah reviewed Apr 24, 2023
View reviewed changes
Comment threaddesktop/containerd/index.md
$ docker ps
CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES
93b4d60dfd08 nginx "/docker-entrypoint.…" 3 seconds ago Up 3 seconds 0.0.0.0:8080->80/tcp stoic_mccarthy
$ docker buildx create --bootstrap

@thaJeztahthaJeztahApr 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering now if we need to show the docker buildx create step at all; would the error-message that's shown above be enough to illustrate what doesn't work without the integration enabled?

@dvdksndvdksnApr 24, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking to keep it, for those who might be familiar with multi-platform builds using the docker-container driver, to illustrate the limitation with --load

@thaJeztahthaJeztahApr 24, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha. Yeah, was wondering if users would potentially run the example (and it's only there to illustrate "this is no longer needed")

@dvdksn

dvdksn commented Apr 26, 2023

Copy link
Copy Markdown
ContributorAuthor

We good with this @rumpl@thaJeztah ?

thaJeztah
thaJeztah approved these changes Apr 27, 2023
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dvdksn@rumpl we should also clean up the "known issues" section (for old Docker Desktop versions), and where needed add new known issues (still to be fixed)

@dvdksn

dvdksn commented Apr 27, 2023

Copy link
Copy Markdown
ContributorAuthor

yes, I have a feeling we have more to say in the limitations section.

@dvdksn
dvdksn merged commit bda1d65 into docker:mainApr 27, 2023
@dvdksn
dvdksn deleted the desktop/refresh-c8d branch May 3, 2023 13:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztahthaJeztahthaJeztah approved these changes
@aevesdockeraevesdockerAwaiting requested review from aevesdocker
+2 more reviewers
@NiklasBrNiklasBrNiklasBr left review comments
@rumplrumplrumpl approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvdksn@rumpl@NiklasBr@thaJeztah