Uh oh!
There was an error while loading. Please reload this page.
registry: prune registry docs - #18390
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
milosgajdos
commented
Oct 11, 2023
PTAL @thaJeztah |
milosgajdos
commented
Oct 11, 2023
When I click on the previews for storage drivers I get |
dvdksn
commented
Oct 11, 2023
@milosgajdos where did you find a link to the storage-drivers page? I thought I'd removed them all The redirects I added in 5ab929b should point you to the markdown files in |
milosgajdos
commented
Oct 11, 2023
Hmm, ok, strange, because they reference full URLs 🤔 |
dvdksn
commented
Oct 11, 2023
@milosgajdos where are you seeing this link? |
milosgajdos
commented
Oct 11, 2023
I go here https://deploy-preview-18390--docsdocker.netlify.app/ then I search for some registry stuff |
dvdksn
commented
Oct 11, 2023
@milosgajdos ah yeah the search index is from production, but we strip the base url prefix from the search results. Those search results will go away once we reindex the site in prod. |
| - /go/filter/ | ||
| # Registry | ||
| "https://github.com/distribution/distribution/blob/main/docs/index.md": |
There was a problem hiding this comment.
should we use permalinks for these (tag or release branch)?
As these are transitional redirects (we stopped publishing these parts of the docs), we probably don't want to continue maintaining the links, and if (some of) these may be removed or may move in upstream, we could get those redirects to be broken otherwise.
There was a problem hiding this comment.
As an alternative, we could create a stub/landing page that describes where docs can be found, and redirect all of these to that page.
There was a problem hiding this comment.
we are working on getting GH pages docs sorted in upstream and will point these docs to those when done
There was a problem hiding this comment.
Yeah, mostly considering that "how to run <some project in the container ecosystem> is somewhat out of scope for our docs, so even with those in place, we should reduce maintenance on our side (and could just point to the upstream github repo)
There was a problem hiding this comment.
PR for publishing registry docs standalone: distribution/distribution#4101
There was a problem hiding this comment.
Removed these redirects and added a stub page at /registry/
f635676 to
641625cCompareRemoves most of the registry docs, keeping only: - How to set up a Docker Hub mirror The canonical location for registry/distribution docs from now on is: https://distribution.github.io/distribution/ Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
<!--Delete sections as needed --> ## Description Re-add registry reference from point in time of deletion at #18390, not upstream. https://deploy-preview-22497--docsdocker.netlify.app/reference/api/registry/latest/https://deploy-preview-22497--docsdocker.netlify.app/reference/api/registry/auth/ ## Related issues or tickets ENGDOCS-2577 ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review --------- Signed-off-by: Craig <craig.osterhout@docker.com> Co-authored-by: sheltongraves <148902861+sheltongraves@users.noreply.github.com> Co-authored-by: Sarah Sanders <sarah.sanders@docker.com>
Removes registry documentation from docs.docker.com
Canonical location for registry/distribution docs is now:
https://distribution.github.io/distribution/
Signed-off-by: David Karlsson 35727626+dvdksn@users.noreply.github.com
Stub preview: /registry/