Uh oh!
There was an error while loading. Please reload this page.
network: add container networking intro from docker run reference - #18753
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| $ docker run -d --name redis example/redis --bind 127.0.0.1 | ||
| $ docker run --rm -it --network container:redis example/redis-cli -h 127.0.0.1 |
There was a problem hiding this comment.
followup: s/redis/nginx/, maybe (not only here but generally)
thaJeztah
left a comment
There was a problem hiding this comment.
two comments/questions, but LGTM otherwise
Uh oh!
There was an error while loading. Please reload this page.
| | Driver | Description | | ||
| | :-------- | :----------------------------------------------------------------------- | | ||
| | `bridge` | The default network driver. | |
There was a problem hiding this comment.
Do we document the Windows drivers, such as nat, default, and transparent anywhere? Also see moby/moby#46447
There was a problem hiding this comment.
Yes, let's create a tracking ticket for this one somewhere. There's quite a gap in our docs in this area because Microsoft at the time decided to document these in their own "container" documentation only, and not to contribute those parts to our docs 😞 (and most of these are not defined in our code, but provided by the Windows API / sdk so we may not even be aware of all options).
thaJeztah
commented
Dec 11, 2023
@dvdksn noticed this one wasn't merged yet; perhaps have a quick peek at my comments 😄 |
This change adds more introductory information about container networking to the networking overview page, moving it from the docker run reference page. Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
| The following flags aren't supported for containers using the `container:` | ||
| networking mode: |
There was a problem hiding this comment.
Some / all of these also apply to host mode networking (in which case the container doesn't have a network-namespace, and no IP-address of its own).
We can look at that in a follow-up as well.
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM; let's go with what we have now, and look at follow-ups.
This change adds more introductory information about container
networking to the networking overview page, moving it from the docker
run reference page.