Skip to content

engine: add chmod a+r for gpg key - #19232

Merged
dvdksn merged 2 commits into
docker:mainfrom
dvdksn:engine-install-chmod-gpg
Jan 26, 2024
Merged

engine: add chmod a+r for gpg key#19232
dvdksn merged 2 commits into
docker:mainfrom
dvdksn:engine-install-chmod-gpg

Conversation

@dvdksn

@dvdksndvdksn commented Jan 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

@dvdksn
engine: add chmod a+r for gpg key
1b49c84
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@netlify

netlifyBot commented Jan 26, 2024•
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for docsdocker ready!

NameLink
🔨 Latest commit6dc6f50
🔍 Latest deploy loghttps://app.netlify.com/sites/docsdocker/deploys/65b3c8e090f3bc0008152ddf
😎 Deploy Previewhttps://deploy-preview-19232--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn
dvdksn requested a review from thaJeztahJanuary 26, 2024 14:27
@github-actionsgithub-actionsBot added the area/install Relates to installing a product label Jan 26, 2024
thaJeztah
thaJeztah previously approved these changes Jan 26, 2024
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah

thaJeztah commented Jan 26, 2024

Copy link
Copy Markdown
Member

It looks like we may also be able to remove gnupg as pre-requisite; docker/docker-install#391

@dvdksn

dvdksn commented Jan 26, 2024

Copy link
Copy Markdown
ContributorAuthor

A good catch, let me remove it

@dvdksn
engine: remove gnupg from install prerequisites
6dc6f50
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn
dvdksn requested a review from thaJeztahJanuary 26, 2024 14:59
@thaJeztah

thaJeztah commented Jan 26, 2024

Copy link
Copy Markdown
Member

At least; I don't think it's there for any reason other than that (I was curious at first, but my docker-install PR looked happy, and I tried it in a container and on a machine without gpg installed, and completed without issues (🎉)

thaJeztah
thaJeztah approved these changes Jan 26, 2024
View reviewed changes

@thaJeztahthaJeztah left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dvdksn

dvdksn commented Jan 26, 2024

Copy link
Copy Markdown
ContributorAuthor

yeah also tried a dind ubuntu install and it didnt complain without gnupg so should be good!

@dvdksn
dvdksn merged commit 43ccf2a into docker:mainJan 26, 2024
@dvdksn
dvdksn deleted the engine-install-chmod-gpg branch January 26, 2024 15:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztahthaJeztahthaJeztah approved these changes

Assignees

@dvdksndvdksn

Labels

area/installRelates to installing a product

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dvdksn@thaJeztah