Uh oh!
There was an error while loading. Please reload this page.
cli: move config etc to base command - #19794
Closed
dvdksn wants to merge 2 commits into
Closed
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
marked this pull request as ready for review
April 12, 2024 13:51
dvdksn
requested review from
aevesdocker, craig-osterhout and stephaurelio
as code ownersApril 12, 2024 13:51
dvdksn
commented
Apr 12, 2024
dvdksn
left a comment
ContributorAuthor
There was a problem hiding this comment.
The description section for the base command becomes very long in this solution. While that's not incorrect in any way, it's unusual. Most of the time, it's the examples section that's overloaded. This means the Options section gets pushed way down. This might not be a blocker, but it's worth acknowledging.
dvdksnforce-pushed
the
cli-reference-base-command-improvements
branch
from
April 12, 2024 14:15
5c82454 to
258a8dcCompareSigned-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksnforce-pushed
the
cli-reference-base-command-improvements
branch
from
July 2, 2024 13:27
258a8dc to
b9ca733Comparedvdksn
commented
Aug 14, 2024
ContributorAuthor
Already merged via #20573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves information about config, env vars, and other how-tos about the Docker CLI to the base command reference page.
https://deploy-preview-19794--docsdocker.netlify.app/reference/cli/docker/
Related issues or tickets
Needs:
Reviews