Uh oh!
There was an error while loading. Please reload this page.
build(bake): update remote bake definitions page - #20889
Merged
Merged
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksnforce-pushed
the
bake-remote-context-cwd
branch
from
September 20, 2024 08:00
f023af0 to
f1bf9d7Compare| name: Build | ||
| uses: docker/bake-action@v4 | ||
| with: | ||
| source: "${{ github.server_url }}/${{ github.repository }}.git#${{ github.ref }}" |
Member
There was a problem hiding this comment.
marking this one for docker/bake-action#193 to remember we need to remove that as follow-up
Member
There was a problem hiding this comment.
crazy-max
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://deploy-preview-20889--docsdocker.netlify.app/build/bake/remote-definition/
Rewrote some of the content, added a section on using local named contexts with
cwd://, and replacedBAKE_CMD_CONTEXTin favor ofcwd://(prefer to have one way of doing something, and thecwd://technique is also available on the client-side so it made sense to me to use the same version in the Bake file).In replacing
BAKE_CMD_CONTEXTI also removed the example showing how to "override" theBAKE_CMD_CONTEXTby passing a second target/argument. This is not supported withcwd://, and it is not clear to me what the use case for it is.