build: cdi manual by crazy-max · Pull Request #23069 · docker/docs

crazy-max · 2025-07-11T11:24:49Z

Description

Adds CDI page to build section.

Related issues or tickets

Reviews

Technical review
Editorial review
Product review

netlify · 2025-07-11T11:25:14Z

✅ Deploy Preview for docsdocker ready!

Name	Link
🔨 Latest commit	`2944e33`
🔍 Latest deploy log	https://app.netlify.com/projects/docsdocker/deploys/687dfe2438aeb60008489e20
😎 Deploy Preview	https://deploy-preview-23069--docsdocker.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

ArthurFlag · 2025-07-11T12:40:34Z

Could you edit this line to

SECRETS_SCAN_OMIT_PATHS = "public/contribute/file-conventions/index.html,public/content/manuals/build/building/cdi.html"

?

crazy-max · 2025-07-11T12:53:50Z

Thanks looks good now but do you know why it is happening? Looking at the logs: https://app.netlify.com/projects/docsdocker/deploys/6870f8f33387050008ca7b11

1:45:06 PM: ❯ Scanning complete. 8540 file(s) scanned. Secrets scanning found 0 instance(s) of secrets and 1 instance(s) of likely secrets in build output or repo code.
1:45:06 PM: 
1:45:06 PM: "LS0t***" detected as a likely secret:
1:45:06 PM: found value at line 719 in public/build/building/cdi/index.html
1:45:06 PM: 
1:45:06 PM: To prevent exposing secrets, the build will fail until these likely secret values are not found in build output or repo files.
1:45:06 PM: 
1:45:06 PM: If these are expected, use SECRETS_SCAN_SMART_DETECTION_OMIT_VALUES, or SECRETS_SCAN_SMART_DETECTION_ENABLED to prevent detecting.
1:45:06 PM: 
1:45:06 PM: For more information on secrets scanning, see the Netlify Docs: https://ntl.fyi/configure-secrets-scanning
1:45:06 PM: 
1:45:06 PM: Secrets scanning detected secrets in files during build. 1:45:06 PM: ────────────────────────────────────────────────────────────────

It says cdi page contains LS0t*** as secret but I don't have any occurrence like this.

ArthurFlag · 2025-07-11T15:35:53Z

The LST0 issue is the one we had a few weeks ago: it comes from codeblocks that we convert into Base64 for the copy button, so one of your codeblocks contains that string once converted 🙃

crazy-max · 2025-07-11T15:57:39Z

The LST0 issue is the one we had a few weeks ago: it comes from codeblocks that we convert into Base64 for the copy button, so one of your codeblocks contains that string once converted 🙃

Ah I see but still wonder why just file-conventions and cdi pages are affected and not others using codeblocks?

thaJeztah · 2025-07-11T22:10:40Z

Ah I see but still wonder why just file-conventions and cdi pages are affected and not others using codeblocks?

I guess just "luck" if the script base64 encodes the content of the codeblock (before styling).

thaJeztah · 2025-07-11T22:14:23Z

Did a quick check; LS0t is --- (base64 encoded)

ArthurFlag

Great stuff. The troubleshooting in the middle of it will be super useful for AI scrapers 👍

thaJeztah

Looks like I started writing some comments that I didn't submit yet 😂

thaJeztah · 2025-07-14T12:56:26Z

+cdiVersion: "0.6.0"
+kind: "vendor1.com/device"
+devices:
+- name: foo


Perhaps we could use some name like my-device instead of foo (probably also for the filename and env-var)

thaJeztah · 2025-07-14T12:57:53Z

+GC Policy rule#0:
+ All: false
+ Filters: type==source.local,type==exec.cachemount,type==source.git.checkout
+ Keep Duration: 48h0m0s
+ Max Used Space: 658.9MiB
+GC Policy rule#1:
+ All: false
+ Keep Duration: 1440h0m0s
+ Reserved Space: 4.657GiB
+ Max Used Space: 953.7MiB
+ Min Free Space: 2.794GiB
+GC Policy rule#2:
+ All: false
+ Reserved Space: 4.657GiB
+ Max Used Space: 953.7MiB
+ Min Free Space: 2.794GiB
+GC Policy rule#3:
+ All: true
+ Reserved Space: 4.657GiB
+ Max Used Space: 953.7MiB
+ Min Free Space: 2.794GiB


Perhaps we should omit these in the example output, as they're not really relevant for this manual, e.g.;
Suggested change
GC Policy rule#0:
All: false
Filters: type==source.local,type==exec.cachemount,type==source.git.checkout
Keep Duration: 48h0m0s
Max Used Space: 658.9MiB
GC Policy rule#1:
All: false
Keep Duration: 1440h0m0s
Reserved Space: 4.657GiB
Max Used Space: 953.7MiB
Min Free Space: 2.794GiB
GC Policy rule#2:
All: false
Reserved Space: 4.657GiB
Max Used Space: 953.7MiB
Min Free Space: 2.794GiB
GC Policy rule#3:
All: true
Reserved Space: 4.657GiB
Max Used Space: 953.7MiB
Min Free Space: 2.794GiB
# ...

thaJeztah · 2025-07-14T13:16:50Z

+Now let's create a container builder named `gpubuilder` using Buildx:
+
+```console
+$ docker buildx create --name gpubuilder --driver-opt "image=crazymax/buildkit:v0.23.2-ubuntu-nvidia" --bootstrap


We probably want to have this somewhere more "official" I guess (not a blocker); how complicated is this image to build? Would it be an option to add the Dockerfile here (if it's just 2 .. 3 steps)?

Yes it will be in the future, this is tracked in moby/buildkit#5944.
Would it be an option to add the Dockerfile here (if it's just 2 .. 3 steps)?
It's the BuildKit Dockerfile so not an option 😅

Gotcha! I was hoping it could be some COPY --from=buildkit-bin ... to compose the image, but based on a different base image.
Definitely not a blocker!

thaJeztah · 2025-07-14T13:20:29Z

+title: Container Device Interface (CDI)
+weight: 60
+description: Using CDI to access GPUs and other devices in your builds
+keywords: build, buildkit, buildx, guide, tutorial, cdi, device, gpu, nvidia, cuda, amd, rocm


Looks like vale may need to be taught some of these acronyms (nvidia, coda ..) or would it be because they're lowercase here?

I think keywords should be excluded from Vale analysis or at least don't check casing

We need to revisit our Vale configuration to include a few more terms to the "allowlist". Yea, excluding metadata could be a good option.

crazy-max · 2025-07-18T12:05:47Z

+> [!NOTE]
+> If you are creating a container builder on WSL, you need to ensure that
+> [Docker Desktop](../../desktop/_index.md) is installed and [WSL 2 GPU Paravirtualization](../../desktop/features/gpu.md#prerequisites)
+> is enabled. Buildx v0.26+ is also required to mount the WSL libraries in the
+> container.


Added this section related to docker/buildx#3320

Removed this part for now as this will happen in the next 0.27 milestone.

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

@tag

follow-up #23069 (comment) ## Related issues or tickets * docker/buildx#3320 ## Reviews   - [ ] Technical review - [ ] Editorial review - [ ] Product review Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

github-actionsBot added the area/build Relates to Dockerfiles or docker build command label Jul 11, 2025

crazy-max force-pushed the build-cdi branch 5 times, most recently from 5465608 to 4ef0c39Compare July 11, 2025 11:43

crazy-max requested review from aevesdocker, colinhemmings, sarahsanders-docker, thompson-shaun and tonistiigi July 11, 2025 11:51

crazy-max marked this pull request as ready for review July 11, 2025 11:51

crazy-max requested a review from ArthurFlag as a code owner July 11, 2025 11:51

github-actionsBot added the area/release Relates to CI or deployment label Jul 11, 2025

ArthurFlag suggested changes Jul 11, 2025
View reviewed changes

Comment threadnetlify.toml Outdated

crazy-max force-pushed the build-cdi branch from 548a489 to d78b285Compare July 11, 2025 12:52

thompson-shaun approved these changes Jul 11, 2025
View reviewed changes

crazy-max force-pushed the build-cdi branch from d78b285 to b56f0e5Compare July 11, 2025 14:47

crazy-max force-pushed the build-cdi branch 2 times, most recently from b0fd26d to 3153d21Compare July 11, 2025 16:09

thaJeztah reviewed Jul 11, 2025
View reviewed changes

Comment threadcontent/manuals/build/building/cdi.md Outdated

ArthurFlag suggested changes Jul 14, 2025
View reviewed changes

Comment threadcontent/manuals/build/building/cdi.md Outdated
Comment threadcontent/manuals/build/building/cdi.md Outdated

crazy-max force-pushed the build-cdi branch from 3153d21 to bdc31c9Compare July 14, 2025 10:22

crazy-max force-pushed the build-cdi branch from bdc31c9 to 919a4caCompare July 14, 2025 10:22

crazy-max requested a review from ArthurFlag July 14, 2025 10:24

ArthurFlag approved these changes Jul 14, 2025
View reviewed changes

thaJeztah reviewed Jul 14, 2025
View reviewed changes

crazy-max force-pushed the build-cdi branch 2 times, most recently from 19103b6 to 266606aCompare July 18, 2025 12:03

crazy-max commented Jul 18, 2025
View reviewed changes

build: cdi manual
2944e33
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

crazy-max force-pushed the build-cdi branch from 266606a to 2944e33Compare July 21, 2025 08:45

crazy-max merged commit 284b194 into docker:mainJul 21, 2025
14 of 15 checks passed

crazy-max deleted the build-cdi branch July 21, 2025 09:12

crazy-max mentioned this pull request Jul 21, 2025
build: cdi page fixes #23123
Merged
3 tasks

crazy-max mentioned this pull request Aug 25, 2025
build: note about cdi usage in WSL #23304
Merged
3 tasks

Uh oh!

Conversation

crazy-max commented Jul 11, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues or tickets

Reviews

Uh oh!

netlifyBot commented Jul 11, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docsdocker ready!

Uh oh!

ArthurFlag commented Jul 11, 2025

Uh oh!

Uh oh!

crazy-max commented Jul 11, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ArthurFlag commented Jul 11, 2025

Uh oh!

crazy-max commented Jul 11, 2025

Uh oh!

thaJeztah commented Jul 11, 2025

Uh oh!

thaJeztah commented Jul 11, 2025

Uh oh!

Uh oh!

ArthurFlag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

thaJeztah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazy-maxJul 15, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

crazy-max commented Jul 11, 2025•
edited
Loading

netlifyBot commented Jul 11, 2025•
edited
Loading

crazy-max commented Jul 11, 2025•
edited
Loading

crazy-maxJul 15, 2025•
edited
Loading