Uh oh!
There was an error while loading. Please reload this page.
Fix grammar in environment variables section - #23620
Closed
ahopp wants to merge 2 commits into
Closed
Conversation
Change "are supported" to "is supported" since the subject is "list" (singular). Fixesdocker#23616
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add clarification that the application may take 10-15 seconds to fully start after running docker compose up. This helps users understand why the app may not be immediately accessible at localhost:3000. Fixesdocker#23500
ahopp
commented
Oct 30, 2025
ContributorAuthor
@sarahsanders-docker@dvdksn Can you take a look? |
dvdksn
reviewed
Oct 31, 2025
| ### Environment variables | ||
| The following list of environment variables are supported by the `docker` command | ||
| The following list of environment variables is supported by the `docker` command |
Contributor
There was a problem hiding this comment.
good catch but unfortunately this file is generated, from this: https://github.com/docker/cli/blob/master/docs/reference/commandline/docker.md
And reading this just now, maybe we could even clarify what we mean here with:
The following environment variables configure the Docker CLI:
Would you mind submitting a PR to docker/cli and dropping it from here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects grammar error in the environment variables section of the Docker CLI documentation. Specifically, the subject of the sentence is "list" (singular), not "environment variables" (plural). The phrase "of environment variables" is a prepositional phrase that modifies "list" but doesn't change the fact that the subject is singular. So updating.
Changes
Changed "The following list of environment variables are supported" to "The following list of environment variables is supported"
Related Issue
Fixes#23616