Skip to content

Add support for memo backend. - #172

Open
mnottale wants to merge 7 commits into
docker:masterfrom
infinit:memo-backend
Open

Add support for memo backend.#172
mnottale wants to merge 7 commits into
docker:masterfrom
infinit:memo-backend

Conversation

@mnottale

Copy link
Copy Markdown

No description provided.

@GordonTheTurtle

Copy link
Copy Markdown

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "memo-backend" git@github.com:infinit/libkv.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@mnottale
mnottaleforce-pushed the memo-backend branch 3 times, most recently from 645556c to 15fd92eCompareJuly 24, 2017 09:32
@Dimrok

Copy link
Copy Markdown

Hi @mnottale.

Could you add some tests, like the other backends please (e.g. zookeeper_test, etcd_test, etc.).

@Dimrok

Copy link
Copy Markdown

Hi @mnottale.

seems good but could you create different PRs for each separate problems you fixed, because:

Matthieu Nottale added 7 commits August 21, 2017 11:52
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Signed-off-by: Matthieu Nottale <matthieu.nottale@docker.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@mnottale@GordonTheTurtle@Dimrok