feat: add variable commit_date

[trim21]

No description provided.

[crazy-max]

#470 has been merged, can you rebase please?

[trim21]

I find a problem, we add Git.commitDate as async function but everything in Meta is synchronously...

[crazy-max]

Missing js artifacts build with docker buildx bake pre-checkin, see: https://github.com/docker/metadata-action/blob/master/.github/CONTRIBUTING.md#submitting-a-pull-request

Missing DCO as well https://github.com/docker/metadata-action/pull/471/checks?check_run_id=32924130175

[trim21]

it will use local event data file for push event, and fallback to github api for PR.

[trim21]

I may need to update GitHub mocking logic for better code style

[trim21]

done

[trim21]

review applied

[trim21]

forget to run eslint 😅

[crazy-max]

Can you add

core.info(`commitDate: ${context.commitDate}`);

to:

metadata-action/src/main.ts

Line 17 in 32323e5

awaitcore.group(`Context info`,async()=>{

[trim21]

done

[crazy-max]

I just merged #472 to check the behavior for git context, can you rebase?

[crazy-max]

I don't think this would work for pull requests from a fork

[trim21]

see this: https://github.com/trim21/metadata-action/pull/2

[crazy-max]

Looking at https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#get-a-commit--parameters I think we can just pass the full ref like:

Suggested change

	constcommit=awaittoolkit.github.octokit.request('GET /repos/{owner}/{repo}/commits/{commit_sha}',{
	commit_sha: sha,
	owner: GitHub.context.repo.owner,
	repo: GitHub.context.repo.repo
	});
	constcommit=awaittoolkit.github.octokit.request('GET /repos/{owner}/{repo}/commits/{GitHub.context.ref}',{
	owner: GitHub.context.repo.owner,
	repo: GitHub.context.repo.repo
	});

In case of a pull request it would be smth like 'GET /repos/{owner}/{repo}/commits/pull/471/merge' for your pr.

[trim21]

no, a commit in a fork will also always exists in any forks. we do not need to handle this

for example: https://github.com/trim21/metadata-action/commit/4a4aa3e4cba597bb90d7342e9a2da7891cb822eb

https://api.github.com/repos/trim21/metadata-action/commits/4a4aa3e4cba597bb90d7342e9a2da7891cb822eb

[crazy-max]

see this: trim21#2

I meant for a pull request from a fork but seems GitHub handles that: https://github.com/docker/metadata-action/actions/runs/11832905758/job/32970605385?pr=471#step:3:18

[trim21]

in anyway, if sha is correct, we will get a commit. even if we send request to head repo not base repo

[crazy-max]

Overall LGTM thanks!

Can we have more test cases in meta.test.ts to cover other kind of events:

• push:

  metadata-action/__tests__/meta.test.ts

  Line 130 in 44d81d6

  describe('push',()=>{

• pr:

  metadata-action/__tests__/meta.test.ts

  Line 2268 in 44d81d6

  describe('pr',()=>{

• pr-head-sha:

  metadata-action/__tests__/meta.test.ts

  Line 2627 in 44d81d6

  describe('pr-head-sha',()=>{

• schedule:

  metadata-action/__tests__/meta.test.ts

  Line 2994 in 44d81d6

  describe('schedule',()=>{

• release:

  metadata-action/__tests__/meta.test.ts

  Line 3250 in 44d81d6

  describe('release',()=>{

[trim21]

done

[crazy-max]

LGTM thanks!

[trim21]

is there a release cycle?

[crazy-max]

is there a release cycle?

Yes probably this week

[trim21]

I forget to add this to toc