Skip to content

distro: add ubuntu 23.10 - #166

Merged
crazy-max merged 1 commit into
docker:mainfrom
rasa:rasa/ubuntu-23.10
Oct 21, 2023
Merged

distro: add ubuntu 23.10#166
crazy-max merged 1 commit into
docker:mainfrom
rasa:rasa/ubuntu-23.10

Conversation

@rasa

@rasarasa commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

relates to docker/docker-ce-packaging#949
relates to docker/containerd-packaging@68ea373 - docker/containerd-packaging#328

Ubuntu 23.10 is planned to be released on October 12, 2023, but final betas are available now.

@rasa

rasa commented Oct 13, 2023

Copy link
Copy Markdown
ContributorAuthor

In the logs for the failed centos7 build

https://github.com/docker/packaging/actions/runs/6487035111/job/17678315850#step:8:35

shows

"GO_VERSION": "1.20.5",

but

https://github.com/docker/packaging/actions/runs/6487035111/job/17678315850#step:8:774

reports this failure:

 #36 100.3 pkg/compose/up.go:64:23: undefined: sync.OnceFunc
#36 100.3 note: module requires Go 1.21

@crazy-max

Copy link
Copy Markdown
Member

In the logs for the failed centos7 build

This has been fixed with #168

Can you rebase? Thanks

Comment threadpkg/docker-cli/Dockerfile
@rasa

rasa commented Oct 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Can you rebase? Thanks

@crazy-max I fixed the conflict. Is that enough? I'm not sure what you want me to rebase against, sorry.

Comment threadMakefile

@crazy-maxcrazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase? Thanks

@crazy-max I fixed the conflict. Is that enough? I'm not sure what you want me to rebase against, sorry.

Can you squash please? Otherwise LGTM thanks!

@rasa

rasa commented Oct 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Can you squash please?

@crazy-max Not a git expert, so I force pushed a single commit. I hope that's OK.

@crazy-maxcrazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-maxcrazy-max left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually you need to add ubuntu2310 here as well:

PKG_DEB_RELEASES ?= debian10 debian11 debian12 ubuntu2004 ubuntu2204 ubuntu2304 raspbian10 raspbian11 raspbian12

Signed-off-by: Ross Smith II <ross@smithii.com>
@rasa

rasa commented Oct 21, 2023

Copy link
Copy Markdown
ContributorAuthor

Oh actually you need to add ubuntu2310 here as well:

@crazy-max Fixed. Sorry I missed that. I mimic'd the 23.04 PR.

@crazy-max
crazy-max merged commit 296d681 into docker:mainOct 21, 2023
@rasa
rasa deleted the rasa/ubuntu-23.10 branch November 10, 2023 01:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@rasa@crazy-max