Uh oh!
There was an error while loading. Please reload this page.
hack/gen-ver: TAGPREFIX to customize tag format - #292
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Fix handling non-standard version tags like: - cmd/cli/v0.1.44 - docker-v29.0.0 Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
crazy-max
approved these changes
Oct 9, 2025
Uh oh!
There was an error while loading. Please reload this page.
| ARG GO_VERSION=1.24.8 | ||
| ARG GO_IMAGE_VARIANT="bookworm" | ||
| ARG TAGPREFIX="cmd/cli/" |
Member
There was a problem hiding this comment.
@vvoland Should we also set TAGPREFIX in docker-engine Dockerfile as well to make it future proof?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix handling non-standard version tags like: