Uh oh!
There was an error while loading. Please reload this page.
pkg(docker-cli,docker-engine): add arm/v5 platform - #78
Merged
Conversation
MemberAuthor
|
tianon
commented
Jan 20, 2023
Contributor
Resulting binaries look OK on my system: 👀 $ cat /proc/cpuinfoprocessor : 0model name : Feroceon 88FR131 rev 1 (v5l)BogoMIPS : 400.00Features : swp half thumb fastmult edsp CPU implementer : 0x56CPU architecture: 5TECPU variant : 0x2CPU part : 0x131CPU revision : 1Hardware : Marvell Kirkwood (Flattened Device Tree)Revision : 0000Serial : 0000000000000000
$ ./dockerd --versionDocker version v0.0.0-20230115001426-98c1140, build 98c1140c4490699d65a2fcd1009570fc0e412550
$ ./docker-init --versiontini version 0.19.0 - git.de40ad0
$ ./docker-proxy --versiondocker-proxy (commit 98c1140c4490699d65a2fcd1009570fc0e412550) version v0.0.0-20230115001426-98c1140 |
crazy-maxforce-pushed
the
armv5
branch
4 times, most recently
from
January 21, 2023 00:23
ad533cf to
e089f95Comparecrazy-max
marked this pull request as ready for review
January 21, 2023 10:42
Comment on lines
+187
to
+195
| FROM build-base-static AS builder-static-nosdk | ||
| ARG DEBIAN_FRONTEND | ||
| RUN apt-get install -y --no-install-recommends dpkg-dev clang lld llvm make pkg-config | ||
| ARG PKG_NAME | ||
| ARG DOCKER_CLI_REF | ||
| ARG NIGHTLY_BUILD | ||
| WORKDIR /build | ||
| ARG TARGETPLATFORM | ||
| RUN xx-apt-get install -y gcc libc6-dev |
Member
There was a problem hiding this comment.
Not sure if it makes a difference for caching, but some questions;
- move the PKG_NAME and some of the other ones later?
- do the
apt-getandxx-apt-getsteps have to be separate? (would it make sense to combine them otherwise?) - does
xx-apt...useTARGETPLATFORM? If not, that one could be moved until after that step as well
Suggested change
| FROM build-base-static AS builder-static-nosdk | |
| ARG DEBIAN_FRONTEND | |
| RUN apt-get install -y --no-install-recommends dpkg-dev clang lld llvm make pkg-config | |
| ARG PKG_NAME | |
| ARG DOCKER_CLI_REF | |
| ARG NIGHTLY_BUILD | |
| WORKDIR /build | |
| ARG TARGETPLATFORM | |
| RUN xx-apt-get install -y gcc libc6-dev | |
| FROM build-base-static AS builder-static-nosdk | |
| WORKDIR /build | |
| ARG DEBIAN_FRONTEND | |
| RUN xx-apt-get install -y --no-install-recommends \ | |
| clang \ | |
| dpkg-dev \ | |
| gcc \ | |
| libc6-dev \ | |
| lld \ | |
| llvm \ | |
| make \ | |
| pkg-config | |
| ARG DOCKER_CLI_REF | |
| ARG NIGHTLY_BUILD | |
| ARG PKG_NAME | |
| ARG TARGETPLATFORM |
MemberAuthor
There was a problem hiding this comment.
- move the PKG_NAME and some of the other ones later?
Yes good point, could be moved after xx-apt
- do the
apt-getandxx-apt-getsteps have to be separate? (would it make sense to combine them otherwise?)
Yes they have because xx-apt-get is using TARGET_PLATFORM.
- does
xx-apt...useTARGETPLATFORM? If not, that one could be moved until after that step as well
Yes every xx-* command needs TARGETPLATFORM.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Avoids issue with dockercore/golang-cross:xx-sdk-extras that doesn't have a dummy linux/arm/v5 platform Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
This was referenced Aug 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.