Skip to content

feat(sdk): retry supervisor layer - #142

Merged
joe0BAB merged 3 commits into
mainfrom
feat/hypervisor
Jul 29, 2025
Merged

feat(sdk): retry supervisor layer#142
joe0BAB merged 3 commits into
mainfrom
feat/hypervisor

Conversation

@joe0BAB

@joe0BABjoe0BAB commented Jul 25, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR adds a new abstraction layer to introduce the retry logic.

Before: Builtin plugins and discovered plugins would be launched directly

After: Builtin plugins and discovered plugins get wrapped with their launcher + retry logic and then later started by the retry supervisor layer. On shutdown, first the supervisor layer is stopped, then all plugins.

Closes#87 .

Base automatically changed from feat/retry-logic to mainJuly 28, 2025 06:54
joe0BAB
joe0BAB commented Jul 28, 2025
View reviewed changes
Comment threadengine/engine_test.go
})
}

func Test_startPlugins(t *testing.T) {

@joe0BABjoe0BABJul 28, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this separate no longer makes sense. It's now tested as part of the engine test.

@joe0BABjoe0BAB self-assigned this Jul 28, 2025
@joe0BAB
joe0BAB requested review from Benehiko and wmlukeJuly 28, 2025 12:49
@joe0BAB
joe0BAB marked this pull request as ready for review July 28, 2025 12:49
@joe0BABjoe0BAB changed the title feat(sdk): retry hypervisor layerfeat(sdk): retry supervisor layerJul 28, 2025
Benehiko
Benehiko reviewed Jul 28, 2025
View reviewed changes
Comment threadengine/engine_test.go Outdated
Comment threadengine/engine_test.go Outdated
Comment threadengine/supervisor.go Outdated
Comment threadengine/engine_test.go Outdated
Comment threadengine/engine_test.go Outdated
@joe0BAB
joe0BAB requested a review from BenehikoJuly 29, 2025 06:56
@joe0BAB
joe0BAB merged commit 157b435 into mainJul 29, 2025
13 checks passed
@joe0BAB
joe0BAB deleted the feat/hypervisor branch July 29, 2025 07:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenehikoBenehikoBenehiko approved these changes
@wmlukewmlukeAwaiting requested review from wmluke

Assignees

@joe0BABjoe0BAB

Labels

None yet

Projects

None yet

Milestone

Secrets Engine V0: Daemon & Plugin Sy...

Development

Successfully merging this pull request may close these issues.

Restart Engine Launched Plugins on Crash

2 participants

@joe0BAB@Benehiko