Skip to content

feat(sdk): stub ipc - #22

Merged
joe0BAB merged 1 commit into
mainfrom
feat/stub-ipc
Jun 23, 2025
Merged

feat(sdk): stub ipc#22
joe0BAB merged 1 commit into
mainfrom
feat/stub-ipc

Conversation

@joe0BAB

@joe0BABjoe0BAB commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@joe0BABjoe0BAB self-assigned this Jun 20, 2025
joe0BAB
joe0BAB commented Jun 20, 2025
View reviewed changes
Comment threadpkg/stub/ipc.go Outdated
close()
}

func NewIPC(sockConn net.Conn, handler http.Handler) (result Ipc, retErr error) {

@joe0BABjoe0BABJun 20, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This export is just temporary to make the linter happy. Will remove once it's used in follow up PR / on the stub.

@joe0BAB
joe0BAB marked this pull request as ready for review June 20, 2025 14:16
@joe0BAB
joe0BAB requested a review from BenehikoJune 20, 2025 14:16
Benehiko
Benehiko reviewed Jun 20, 2025
View reviewed changes

@BenehikoBenehiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this code is hard to read, it's doing a lot of things which aren't too obvious.

I'll have to think a bit more about how we can separate the implementation details

Comment threadpkg/stub/ipc.go Outdated
Comment threadpkg/stub/ipc.go
Comment threadpkg/stub/ipc.go Outdated
Comment threadpkg/stub/ipc.go Outdated
Comment threadpkg/stub/ipc.go Outdated
Comment threadpkg/stub/ipc.go Outdated
Comment threadpkg/stub/ipc.go Outdated
@joe0BAB
joe0BABforce-pushed the feat/stub-ipc branch 2 times, most recently from 317338f to c89f8e7CompareJune 20, 2025 14:57
@joe0BABjoe0BAB linked an issue Jun 23, 2025 that may be closed by this pull request
Stub (plugin client SDK part) V0 #27
Closed
@joe0BAB
joe0BABforce-pushed the feat/stub-ipc branch 4 times, most recently from 4c16bca to dbcbf2bCompareJune 23, 2025 08:54
Benehiko
Benehiko reviewed Jun 23, 2025
View reviewed changes

@BenehikoBenehiko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better!
Just a small nit

Comment threadpkg/stub/ipc.go Outdated
@joe0BAB
joe0BAB merged commit 696ae65 into mainJun 23, 2025
@joe0BAB
joe0BAB deleted the feat/stub-ipc branch June 23, 2025 09:14
@joe0BABjoe0BAB mentioned this pull request Jun 23, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenehikoBenehikoBenehiko approved these changes

Assignees

@joe0BABjoe0BAB

Labels

None yet

Projects

None yet

Milestone

Secrets Engine V0: Daemon & Plugin Sy...

Development

Successfully merging this pull request may close these issues.

Stub (plugin client SDK part) V0

2 participants

@joe0BAB@Benehiko