Uh oh!
There was an error while loading. Please reload this page.
feat(sdk): added missing protobuf fields - #96
Merged
Merged
Conversation
Benehiko
approved these changes
Jul 9, 2025
joe0BABforce-pushed
the
feat/engine
branch
3 times, most recently
from
July 10, 2025 06:53
634a886 to
84b08b0Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds missing fields from GetSecret
enveloperesponse object (secrets-engine/pkg/secrets/secrets.go
Line 25 in 41afad2
Providerfield to the request object passed through the protobuf/IPC layers.There are still fields in the request object that still aren't implemented yet and up for further follow up PRs.