Skip to content

fix: include furniture field in DoclingDocument - #387

Merged
edeandrea merged 1 commit into
docling-project:mainfrom
mohammedfaisal:fix/furniture-field-missing-in-docling-document
Mar 12, 2026
Merged

fix: include furniture field in DoclingDocument#387
edeandrea merged 1 commit into
docling-project:mainfrom
mohammedfaisal:fix/furniture-field-missing-in-docling-document

Conversation

@mohammedfaisal

@mohammedfaisalmohammedfaisal commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Fixes#386:

  • Add field furniture to DoclingDocument.java

@edeandreaedeandrea changed the title Fix #386: include furniture field in DoclingDocumentfix: include furniture field in DoclingDocumentMar 7, 2026
@edeandrea

edeandrea commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Thanks for this @mohammedfaisal !

Could you please fix the DCO (i.e. you probably did not sign your commit) & amend your commit so it passes the Semantic PR spec?

@edeandrea

edeandrea commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Also, could you please add something to the existing test cases for this field?

@github-actions

github-actionsBot commented Mar 7, 2026•
edited
Loading

Copy link
Copy Markdown

:java_duke: JaCoCo coverage report

Overall Project46.77%🔴

There is no coverage information present for the Files changed

@github-actions

github-actionsBot commented Mar 7, 2026•
edited
Loading

Copy link
Copy Markdown
TestsPassed ✅SkippedFailed
Gradle Test Results (all modules & JDKs)954 ran954 passed0 skipped0 failed
TestResult
No test annotations available

@github-actions

github-actionsBot commented Mar 7, 2026

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@mohammedfaisal
mohammedfaisalforce-pushed the fix/furniture-field-missing-in-docling-document branch from eafebb4 to 1b6d051CompareMarch 9, 2026 06:11
@mohammedfaisal

mohammedfaisal commented Mar 9, 2026

Copy link
Copy Markdown
ContributorAuthor

Hi @edeandrea

I've fixed the DCO, updated the commit message to follow the Semantic PR spec, and added test cases for the furniture field. Please take a look when you get a chance.

@mohammedfaisal
mohammedfaisalforce-pushed the fix/furniture-field-missing-in-docling-document branch from 1b6d051 to 7bcebc2CompareMarch 9, 2026 06:29
@edeandrea

edeandrea commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Hi @mohammedfaisal sorry for the delay in getting to this - I've been out of the office for 2 weeks and I'm still catching up. I will get to this!

@github-actions

github-actionsBot commented Mar 11, 2026

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@mohammedfaisal@edeandrea
fix: include furniture field in DoclingDocument
d8eb2f2
Fixesdocling-project#386
Signed-off-by: Mohammed Faisal <mohammedfaisal@users.noreply.github.com>
@edeandrea
edeandreaforce-pushed the fix/furniture-field-missing-in-docling-document branch from 7bcebc2 to d8eb2f2CompareMarch 12, 2026 17:12
@edeandrea

edeandrea commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

@all-contributors add @mohammedfaisal for code, tests

@allcontributorsallcontributorsBot mentioned this pull request Mar 12, 2026
Merged
@allcontributors

allcontributorsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

@edeandrea

I've put up a pull request to add @mohammedfaisal! 🎉

@edeandrea
edeandrea enabled auto-merge (squash) March 12, 2026 17:12
@edeandrea

edeandrea commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Thanks @mohammedfaisal for this! I've updated it from main and set it to auto-merge once all the checks pass.

@github-actions

github-actionsBot commented Mar 12, 2026

Copy link
Copy Markdown

HTML test reports are available as workflow artifacts (zipped HTML).

• Download: Artifacts for this run

@edeandrea
edeandrea merged commit f08e436 into docling-project:mainMar 12, 2026
22 checks passed
@docling-java-opsdocling-java-opsBot added the released Issue has been released label Mar 19, 2026
@docling-java-ops

docling-java-opsBot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

🎉 This issue has been resolved in v0.5.0 (Release Notes)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edeandreaedeandreaedeandrea approved these changes
+1 more reviewer
@oscerdoscerdoscerd approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

releasedIssue has been released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

furniture field missing from DoclingDocument JSON serialized via docling-java

3 participants

@mohammedfaisal@edeandrea@oscerd