support docsify init --plugins by tool3 · Pull Request #99 · docsifyjs/docsify-cli

tool3 · 2020-03-12T19:49:16Z

having a go at #98 .

command: init
option: --plugins, -p

plugins are now supported via the following usage:
docsify init docs/ -p search gitalk <some_other_plugin>

note that by default a plugin will be added as a script tag with a url pointing to https://unpkg.com/docsify/lib/plugins/<plugin_name> otherwise it will use the url provided as an argument.

example and documentation was added to docs/README

anikethsaha

It looks like you removed the main readme ! please revert it .
there are unncessary files like .nojekyll , index.html etc in root. Please check.
please add tests as well

tool3 · 2020-03-13T07:29:32Z

sorry about that! have no idea where those came from 👀

by tests do you mean adding a test to the ava snapshot e2e ?

Thanks !

tool3 · 2020-03-13T08:40:31Z

okay so I added tests but in order to do that I had to change the test structure a bit to accept command help.

let me know what you think 🤘🏼

anikethsaha · 2020-03-13T09:19:16Z

Thanks ! I will review it soon

anikethsaha

Apologizes for the delay. Completely lost track of this.

noraj · 2021-04-28T08:09:55Z

@anikethsaha is that possible to re-review?

sy-records · 2021-04-28T08:49:28Z

+ replace(target(filename), '_plugins_', '_plugin\n '.repeat(plugins.length))
+ plugins.forEach(plugin => {
+ const major = version[0]
+ const url = plugin.includes('//') ? plugin : `https://cdn.jsdelivr.net/npm/docsify@${major}/lib/plugins/${plugin}.min.js`


if use ./bin/docsify init docs2 -p 1, An exception will be thrown here

I added the enquirer in #117, you can use this here as well.
see https://github.com/enquirer/enquirer#multiselect-prompt

Ideally, we should support specifying a list of plugins as an argument to --plugins such that the prompt shows up on not supplying any or passing in an unsupported plugin.
docsify init [path] --plugins, -p [...plugins]

docsifyjs#99 (comment)

sy-records · 2021-05-19T06:59:31Z

resolve #99 (comment) .

When executing the init command, the user may not know which plugins he wants to use and the corresponding plugin names

jamesgeorge007 · 2021-05-26T18:44:10Z

resolve #99 (comment) .
When executing the init command, the user may not know which plugins he wants to use and the corresponding plugin names

The success message should come after the prompt.

Co-authored-by: James George <jamesgeorge998001@gmail.com>

sy-records · 2021-05-27T03:28:37Z

The success message should come after the prompt.

done.

sy-records · 2021-05-28T02:36:33Z

@jamesgeorge007 Thank you for the modifications 790e96c

But there seems to be some problems:

use ctrl+c , will output the help message

use ctrl+c, The docs-test directory is created, but the tip message is missing

Initialization succeeded! Please run docsify serve docs-test/

jamesgeorge007 · 2021-05-28T06:11:29Z

Good catch. I've pushed a fix

tool3 added 4 commits March 12, 2020 20:23

feat: adding plugins support
ee76d17

fix: fixing url
8b9fccb

fix: removing temp docs
21a097f

docs: adding documentation for init --plugins
a078e08

anikethsaha requested changes Mar 12, 2020
View reviewed changes

tool3 added 2 commits March 13, 2020 09:27

fix: removing unused files
b8b89c7

fix: removing .nojekyll top-level
64b32e0

chore: adding tests
f522d07

anikethsaha requested changes Mar 13, 2020
View reviewed changes

Comment threadREADME.md

fix: fixing docs links
e532c1e

anikethsaha self-requested a review March 13, 2020 09:19

anikethsaha self-assigned this Mar 13, 2020

tool3 added 2 commits March 13, 2020 15:33

refactor: cleaner matchSnapshot
6558cee

fix: removing redundant spread
5431de3

tool3 mentioned this pull request Mar 20, 2020
Add plugin? tool3/docsify-action#1
Closed

anikethsaha requested changes Jun 17, 2020
View reviewed changes

Comment threadlib/commands/init.js Outdated

anikethsaha mentioned this pull request Jun 17, 2020
support plugins with docsify init #98
Closed

tool3 added 3 commits June 18, 2020 11:29

fix(init): adding jsdelivr and major version to plugins init
1083bec

fix: realigning with remote
54dd557

fix(e2e): recreating index snap with latest docsify version
de9bcce

jhildenbiddle linked an issue Jun 18, 2020 that may be closed by this pull request
support plugins with docsify init #98
Closed

Merge branch 'master' into master
3c547f9

tool3 requested a review from anikethsaha June 22, 2020 11:29

sy-records requested a review from jamesgeorge007 April 28, 2021 08:41

sy-records requested changes Apr 28, 2021
View reviewed changes

Comment threadREADME.md Outdated
Comment threaddocs/README.md Outdated

sy-records added 6 commits April 29, 2021 10:36

chore: Optimize code to ensure equal indentation
272e310

Merge branch 'master' into tool3/master
c83fa11

chore: update snap
f3e717c

chore: update snap
e48d7a8

chore: update zh.json
f96f6d5

fix: the exception caused by the plugin name being a number
2debff8
docsifyjs#99 (comment)

sy-records requested a review from QingWei-Li May 19, 2021 03:12

Use MultiSelect
6f26f05

Update README
1b7f8f2

QingWei-Li approved these changes May 19, 2021
View reviewed changes

sy-records requested a review from a teamMay 25, 2021 10:39

jamesgeorge007 reviewed May 26, 2021
View reviewed changes

Comment threadlib/commands/init.js Outdated

sy-recordsand others added 3 commits May 27, 2021 09:35

Update lib/commands/init.js
f2943a1
Co-authored-by: James George <jamesgeorge998001@gmail.com>

Update msg
e1118d5

Fix missing msg
63e9d95

sy-records requested a review from jamesgeorge007 May 27, 2021 03:28

refactor: simplify code with async/await
790e96c

jamesgeorge007 approved these changes May 27, 2021
View reviewed changes

sy-records requested a review from jamesgeorge007 May 28, 2021 02:36

chore: handle user interruptions
149bd81

jamesgeorge007 removed their request for review May 28, 2021 06:10

jamesgeorge007 requested a review from sy-records May 28, 2021 06:11

sy-records approved these changes May 28, 2021
View reviewed changes

Update README
828b672

sy-records merged commit 8bb295c into docsifyjs:masterJun 11, 2021

Uh oh!

Uh oh!

Conversation

tool3 commented Mar 12, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anikethsaha left a comment

Choose a reason for hiding this comment

Uh oh!

tool3 commented Mar 13, 2020

Uh oh!

tool3 commented Mar 13, 2020

Uh oh!

Uh oh!

anikethsaha commented Mar 13, 2020

Uh oh!

anikethsaha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

noraj commented Apr 28, 2021

Uh oh!

sy-recordsApr 28, 2021

Choose a reason for hiding this comment

Uh oh!

sy-recordsApr 28, 2021

Choose a reason for hiding this comment

Uh oh!

jamesgeorge007May 27, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sy-records commented May 19, 2021

Uh oh!

Uh oh!

jamesgeorge007 commented May 26, 2021

Uh oh!

sy-records commented May 27, 2021

Uh oh!

sy-records commented May 28, 2021

Uh oh!

jamesgeorge007 commented May 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tool3 commented Mar 12, 2020•
edited
Loading

jamesgeorge007May 27, 2021•
edited
Loading