Feature request
- Add response status to
route object - Make response status available to plugin hooks
- Identify and handle request errors properly (not just 404)
Problem or desire
- Internally, Docsify does not know response status details about the current route beyond basic success/error. This makes it difficult for contributors to handle various request errors properly.
- Externally, Docsify does not expose response status details to plugin authors. This makes it difficult fro plugin authors to handle various request errors properly.
As a result of the two issues above:
- Docsify incorrectly treats successful requests for empty markdown files as 404 errors. Docsify should handle empty pages properly and display an empty page as expected.
- Docsify assumes all failed requests are 404 errors and displays "404 - Not found" in the content area. This is misleading when requests fail for reasons other than a 404 error. Docsify should be able to identify and display all request error codes and status messages.
Proposal
Current route object:
{file: "README.md",path: "/",query: {}}Proposed route object:
// Success{file: "README.md",path: "/",query: {},response: {ok: true,status: 200,statusText: "OK"}}// Failure{file: "README.md",path: "/",query: {},response: {ok: false,status: 404,statusText: "Not Found"}}Plugin access:
window.$docsfy={// ...plugins: [function(hook,vm){hook.beforeEach(html=>{console.log(vm.route.response.ok);// trueconsole.log(vm.route.response.status);// 200console.log(vm.route.response.statusText);// "OK"}}],};Implementation
See above.
Feature request
routeobjectProblem or desire
As a result of the two issues above:
Proposal
Current
routeobject:Proposed
routeobject:Plugin access:
Implementation
See above.