Uh oh!
There was an error while loading. Please reload this page.
Updated embed to strip YAML front matter fixes #1129 - #1148
Conversation
Update embeded files documentation Add example with front matter Add various comments I used to understand code Updated front matter to have installed flag Added function to parse front matter Added intercept to remove front matter for embed
anikethsaha
commented
Apr 28, 2020
thanks for the PR. It will be reviewed soon 👍 |
Koooooo-7
left a comment
There was a problem hiding this comment.
After test, it works that skipped the YAML header. 👍
Uh oh!
There was an error while loading. Please reload this page.
sytone
commented
Apr 30, 2020
Any other questions on this one? Also if this goes into develop what is the propagation to master/release? I am considering pulling develop locally building and referencing that locally until pushed if it will take a while. This is an awesome system. I'm am building/using a personal journal system out of it as I write notes and journal entries in markdown to start with. Just have a simple powershell web server running it all. |
anikethsaha
commented
Apr 30, 2020
I think its good. I will do a final review this weekend and will do a release by Monday 👍 |
sytone
commented
May 4, 2020
Just following up to see if there were any issues. |
Summary
This fixes#1129 where embed was pulling through the YAML header when rendering pages as an embed. I did not want to pull the YAML parser by default. There are no rendering hooks for embed so I added a flag to check to see if the front matter plugin is installed and if it is use it to strip the content before returning the txt to render to the page.
FYI: I am not a JavaScript developer. :)
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
libdirectory.