Skip to content

Fix Vue Reactivity - #1271

Merged
jhildenbiddle merged 11 commits into
developfrom
fix-790
Oct 8, 2020
Merged

Fix Vue Reactivity#1271
jhildenbiddle merged 11 commits into
developfrom
fix-790

Conversation

@jhildenbiddle

@jhildenbiddlejhildenbiddle commented Jul 5, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#788#790#1074#1252#1364

  • Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2) skipping elements that are already Vue instances
  • Retain previous behavior of handling basic Vue rendering without the need for a markdown <script> tag.
  • Add Vue3 support
  • Update documentation and add live Vue examples
  • Update index.html files to include Vue.js
  • Update Cypress Jest+Playwright e2e tests

Summary: Docsify was mounting #main as a Vue component on every page change when it detected Vue.js, presumably to process basic Vue content without requiring a <script> tag in each markdown file. The issue is that this was happening after users had already instantiated child elements of #main as Vue components, destroying those instances.

@jhildenbiddle
Fix Vue compatibility (fix#790)
f385e21
- Fix inability to instantiate reactive Vue components by 1) handling each child of #main instead of #main itself and 2) skipping elements that are already Vue instances
- Retain previous behavior of processing basic Vue rendering without the need for a markdown <script> tag.
- Update documentation and add live Vue examples
- Update `index.html` files to include Vue.js and Vuep (CSS+JS)
@jhildenbiddle
Merge branch 'develop' into fix-790
aa1d1e6
# Conflicts:
#	docs/index.html
@vercel

vercelBot commented Jul 5, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/gw3jsrcph
✅ Preview: https://docsify-preview-git-fix-790.docsify-core.vercel.app

@codesandbox-ci

codesandbox-ciBot commented Jul 5, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4f6148d:

SandboxSource
docsify-templateConfiguration

jhildenbiddle
jhildenbiddle commented Jul 5, 2020
View reviewed changes
Comment threadsrc/core/render/index.js
anikethsaha
anikethsaha approved these changes Jul 5, 2020
View reviewed changes

@anikethsahaanikethsaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really awesome

@jhildenbiddlejhildenbiddle self-assigned this Jul 5, 2020
Koooooo-7
Koooooo-7 previously approved these changes Jul 5, 2020
View reviewed changes

@Koooooo-7Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! 👍

anikethsaha
anikethsaha previously approved these changes Jul 5, 2020
View reviewed changes
sy-records
sy-records previously approved these changes Jul 5, 2020
View reviewed changes
trusktr
trusktr previously requested changes Jul 5, 2020
View reviewed changes

@trusktrtrusktr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, but let's add unit tests.

Comment threaddocs/index.html Outdated
Comment threadsrc/core/render/index.js
@anikethsaha

anikethsaha commented Jul 5, 2020

Copy link
Copy Markdown
Member

This is a good change, but let's add unit tests.

tests fixtures (e2e-cypress) have been updated. But yea unit/integration tests would be great to add. But is it possible to do unit testing for this change ? if so, it would be great to add.

trusktr
trusktr reviewed Jul 5, 2020
View reviewed changes
Comment threadsrc/core/render/index.js Outdated
trusktr
trusktr reviewed Jul 5, 2020
View reviewed changes
Comment threadsrc/core/render/index.js Outdated
@jhildenbiddlejhildenbiddle mentioned this pull request Jul 5, 2020
Closed
1 task
@jhildenbiddlejhildenbiddle linked an issue Jul 5, 2020 that may be closed by this pull request
Dynamic content in Vue components #1074
Closed
1 task
@jhildenbiddle
Updates per request
105fbbf
- When Vue.js is detected, markdown `<script>` is not executed when executeScript is `false` (matches previous behavior)
- Minor code tweaks that do not affect functonality
@jhildenbiddlejhildenbiddle mentioned this pull request Jul 8, 2020
Merged
18 tasks
@jhildenbiddlejhildenbiddle added the vuejs related to Vue.js label Jul 8, 2020
anikethsaha
anikethsaha previously approved these changes Oct 7, 2020
View reviewed changes
@jhildenbiddle
jhildenbiddle dismissed trusktr’s stale reviewOctober 7, 2020 20:48

Outdated / Issues Resolved

This was referenced Oct 7, 2020
Closed
Closed
Closed
@jhildenbiddlejhildenbiddle linked an issue Oct 8, 2020 that may be closed by this pull request
How to create global vue variables in html and make it readable on .md files? #1252
Closed
This was linked to issues Oct 8, 2020
Vue not working with reactivity #790
Closed
Support Vue3 #1364
Closed
@jhildenbiddle
jhildenbiddle merged commit 761210c into developOct 8, 2020
This was referenced Oct 8, 2020
Closed
Closed
@jhildenbiddle
jhildenbiddle deleted the fix-790 branch October 8, 2020 22:07
@sy-recordssy-records mentioned this pull request Feb 5, 2021
Merged
3 tasks
This was referenced Mar 9, 2021
Merged
Open
Closed
Merged
@dependabotdependabotBot mentioned this pull request Mar 17, 2021
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anikethsahaanikethsahaanikethsaha approved these changes
@sy-recordssy-recordssy-records approved these changes
@trusktrtrusktrAwaiting requested review from trusktr
@Koooooo-7Koooooo-7Awaiting requested review from Koooooo-7

Assignees

@jhildenbiddlejhildenbiddle

Labels

vuejsrelated to Vue.js

Projects

None yet

Milestone

No milestone

5 participants

@jhildenbiddle@anikethsaha@trusktr@Koooooo-7@sy-records