Skip to content

Docs: added carbon ad - #1337

Merged
anikethsaha merged 2 commits into
developfrom
carbonAds
Aug 17, 2020
Merged

Docs: added carbon ad#1337
anikethsaha merged 2 commits into
developfrom
carbonAds

Conversation

@anikethsaha

@anikethsahaanikethsaha commented Aug 16, 2020

Copy link
Copy Markdown
Member

Added CarbonAds

@vercel

vercelBot commented Aug 16, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/4wtw3y61l
✅ Preview: https://docsify-preview-git-carbonads.docsify-core.vercel.app

@codesandbox-ci

codesandbox-ciBot commented Aug 16, 2020•
edited
Loading

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 450189d:

SandboxSource
docsify-templateConfiguration

sy-records
sy-records reviewed Aug 16, 2020
View reviewed changes
Comment threaddocs/index.html Outdated
@anikethsahaanikethsaha added priority : high website related to the official docsify website: https://docsify.js.org labels Aug 16, 2020
Koooooo-7
Koooooo-7 reviewed Aug 16, 2020
View reviewed changes

@Koooooo-7Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sy-records I agree we can use that ads plugin or we can write the style instead of importing extra resource.

@anikethsaha

anikethsaha commented Aug 16, 2020

Copy link
Copy Markdown
MemberAuthor

agreed let's use the plugin

@anikethsaha
anikethsaha changed the base branch from develop to masterAugust 17, 2020 14:34
@anikethsaha
anikethsaha changed the base branch from master to developAugust 17, 2020 14:34
@anikethsaha

anikethsaha commented Aug 17, 2020

Copy link
Copy Markdown
MemberAuthor

We will need to release a version once it is merged in develop, I can directly submit a PR against master as there would be conflicts.

Koooooo-7
Koooooo-7 approved these changes Aug 17, 2020
View reviewed changes

@Koooooo-7Koooooo-7 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I m just working on it also, it seems a litte big.
LGTM.

@anikethsaha

anikethsaha commented Aug 17, 2020

Copy link
Copy Markdown
MemberAuthor

I m just working on it also, it seems a litte big.

yeah if PR against master then the diff is quite big, We need to release it at the earliest

@anikethsaha
anikethsaha merged commit cc071c5 into developAug 17, 2020
@sy-records
sy-records deleted the carbonAds branch August 17, 2020 14:59
@snyk-botsnyk-bot mentioned this pull request Aug 21, 2020
Closed
@snyk-botsnyk-bot mentioned this pull request Sep 12, 2020
Merged
@jhildenbiddlejhildenbiddle mentioned this pull request Mar 10, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Koooooo-7Koooooo-7Koooooo-7 approved these changes
@sy-recordssy-recordssy-records approved these changes
@trusktrtrusktrAwaiting requested review from trusktr
@jhildenbiddlejhildenbiddleAwaiting requested review from jhildenbiddle

Assignees

No one assigned

Labels

priority : highwebsiterelated to the official docsify website: https://docsify.js.org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anikethsaha@Koooooo-7@sy-records@trusktr