Skip to content

Fix git commit typo#1347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Koooooo-7 merged 2 commits into from
Aug 22, 2020
Merged

Fix git commit typo #1347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40c8280
Update README.md
alphaX86 Aug 21, 2020
5041399
Make changes after reviewing
alphaX86 Aug 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -84,7 +84,7 @@ So that you can start straight away.

- Fork it!
- Create your feature branch: `git checkout -b my-new-feature`
- Commit your changes: `git commit -am 'Add some feature'`
- Commit your changes: `git add . && git commit -m 'Add some feature'`

@trusktrtrusktrAug 22, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's the same thing, but I always use git add.

@alphaX86alphaX86Aug 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same thing, but I didn't use this -am flag all time. So yeah!

@Koooooo-7Koooooo-7Aug 23, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically, it is just a litte different that git commit -am wont commit those untracked files(the new files you create).

- Push to the branch: `git push origin my-new-feature`
- Submit a pull request

Expand Down