Uh oh!
There was an error while loading. Please reload this page.
feat: add loadNavbarOnCover configuration - #1376
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/jbpg8v8eg |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1f9e427:
|
anikethsaha
left a comment
There was a problem hiding this comment.
One change, other than that, LGTM
Uh oh!
There was an error while loading. Please reload this page.
Koooooo-7
left a comment
There was a problem hiding this comment.
Little problem.
Steps:
- set
loadNavbarOnCover: false,. - clink to another selection.
- clink the
backbutton of the browser, it will back to the cover page.
the nav will show on the cover now.
sy-records
commented
Sep 19, 2020
This is caused by not reloading the page, I think that's acceptable. |
It make no sense, there is no reason to make an element visible, which had been set // Load navif(loadNavbar){// default show the navdocument.querySelector('.app-nav').style.display='inline';if(path==='/'&&!loadNavbarOnCover){// hidden nav on coverdocument.querySelector('.app-nav').style.display='none';return;}Maybe you could get another brilliant one :). |
fix Update docs.index.html fix fix fix Update docs.index.html fix Update docs.index.html fix remove test Update docs.index.html update
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Summary
resolve#1375
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx], where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.