chore(deps): bump marked from 1.2.9 to 2.0.0 by dependabot[bot] · Pull Request #1503 · docsifyjs/docsify

dependabot · 2021-02-09T07:18:12Z

Bumps marked from 1.2.9 to 2.0.0.

Release notes

v2.0.0
2.0.0 (2021-02-07)
Bug Fixes
Join adjacent inlineText tokens (#1926) (f848e77)
Total rework of Emphasis/Strong (#1864) (7293251)
BREAKING CHANGES
em and strong tokenizers have been merged into one emStrong tokenizer.
code and text tokenizers do not get passed all tokens as a second parameter.
No longer supporting IE 11. IE 11 may still work but we are not committed to making sure it works with every update. We still provide an es5 version in lib/marked.js but some pollyfills may be needed for IE 11 in the future.

Commits

8a7502f chore(release): 2.0.0 [skip ci]
9d3a781 🗜️ build [skip ci]
7293251 fix: Total rework of Emphasis/Strong (#1864)
f848e77 fix: Join adjacent inlineText tokens (#1926)
See full diff in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@dependabot use these labels will set the current labels as the default for future PRs for this repo and language
@dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
@dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
@dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [marked](https://github.com/markedjs/marked) from 1.2.9 to 2.0.0. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v1.2.9...v2.0.0) Signed-off-by: dependabot[bot] <support@github.com>

vercel · 2021-02-09T07:18:16Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/7BA56oF8TjJqhhTfR8pNczAuadwH
✅ Preview: https://docsify-previe-git-dependabot-npmandyarnmarked-200-docsi-dffd83.vercel.app

codesandbox-ci · 2021-02-09T07:19:53Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9997779:

Sandbox	Source
docsify-template	Configuration

sy-records

https://github.com/markedjs/marked/releases/tag/v2.0.0

BREAKING CHANGES

em and strong tokenizers have been merged into one emStrong tokenizer.
code and text tokenizers do not get passed all tokens as a second parameter.
No longer supporting IE 11. IE 11 may still work but we are not committed to making sure it works with every update. We still provide an es5 version in lib/marked.js but some pollyfills may be needed for IE 11 in the future.

Koooooo-7

IE11 is not LTS tho.😬

thijstriemstra · 2021-02-16T16:03:42Z

This should be high priority since marked < 2.0 is vulnerable to ReDOS:

A Denial of Service attack can affect anyone who runs user generated code through marked.

markedjs/marked#1927
https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS

Koooooo-7 · 2021-02-16T16:13:33Z

This should be high priority since marked < 2.0 is vulnerable to DDOS:
A Denial of Service attack can affect anyone who runs user generated code through marked.
markedjs/marked#1927
https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS

thx a lot, we will check it soon. 👍

thijstriemstra · 2021-02-26T23:01:53Z

@Koooooo-7 any idea when this will be merged and released?

Koooooo-7 · 2021-02-27T04:52:41Z

@Koooooo-7 any idea when this will be merged and released?

we need have tests on those changes first, and discuss if we need still support the IE11 in future.

I wonder that if you could provide a case to reproduce the DDos on docsify , it will help a lot :)
thx.

thijstriemstra · 2021-02-27T12:56:52Z

I wonder that if you could provide a case to reproduce the DDos on docsify , it will help a lot :)
thx.

Create a page with the following content:

_______________________________ ____________________ __________________________ a

and you'll see that the page will throw this error:

 Uncaught InternalError: too much recursion
strong http://unpkg.com/docsify/lib/docsify.min.js:1
inlineTokens http://unpkg.com/docsify/lib/docsify.min.js:1
inline http://unpkg.com/docsify/lib/docsify.min.js:1
lex http://unpkg.com/docsify/lib/docsify.min.js:1
lex http://unpkg.com/docsify/lib/docsify.min.js:1
On http://unpkg.com/docsify/lib/docsify.min.js:1
_renderMain http://unpkg.com/docsify/lib/docsify.min.js:1
a http://unpkg.com/docsify/lib/docsify.min.js:1
W http://unpkg.com/docsify/lib/docsify.min.js:1
_renderMain http://unpkg.com/docsify/lib/docsify.min.js:1
_fetch http://unpkg.com/docsify/lib/docsify.min.js:1
then http://unpkg.com/docsify/lib/docsify.min.js:1

Tested on MacOS 10.15.7 with Firefox 86.0

Koooooo-7 · 2021-02-27T13:21:33Z

@thijstriemstra thx a lot !
IMO, it is a content which wrote by users themselves and it doesnt make sense. I dont think it is vulnerable for ReDDos rn.
but yea, absolutely, If a user insert a content like this, it will make the site crushed and it needs fix.
@docsifyjs/reviewers It is a potential bug, WDYT?

klsember · 2021-03-10T18:47:18Z

Just wondering if there's any ETA when this would be merged, due to the high vulnerability? Thanks!

Koooooo-7 · 2021-03-11T00:42:29Z

Just wondering if there's any ETA when this would be merged, due to the high vulnerability?
Thanks!

Hi.
After our discussion on it. it's not the high vulnerability to users, either to docsify.
User knows what they write to their own site , it it's under control.
We may sync the IE11 supports until v5.

Yash-Singh1 · 2021-05-07T18:27:54Z

I am getting an npm audit report:

npm audit report

marked 1.1.1 - 1.2.9
Severity: moderate
Regular Expression Denial of Service - https://npmjs.com/advisories/1623
fix available via npm audit fix --force
Will install docsify@4.11.4, which is a breaking change
node_modules/marked
docsify >=4.11.5
Depends on vulnerable versions of marked
node_modules/docsify

Currently I have docsify 4.12.0.

It would be a good idea to merge this and resolve a security issue.

dependabot · 2022-01-15T01:03:11Z

A newer version of marked exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Yash-Singh1 · 2022-01-15T01:24:51Z

Another thing to note before merging this:

No longer supporting IE 11. IE 11 may still work but we are not committed to making sure it works with every update. We still provide an es5 version in lib/marked.js but some pollyfills may be needed for IE 11 in the future.

I think its one of docsify's features to have compatibility with IE11:

Compatible with IE11

dependabot · 2023-05-27T05:45:58Z

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabotBot added the dependencies Pull requests that update a dependency file label Feb 9, 2021

vercelBotdeployed to Preview February 9, 2021 07:18 View deployment

sy-records added do not merge semver-major This needs a major release labels Feb 9, 2021

sy-records requested changes Feb 9, 2021
View reviewed changes

Koooooo-7 reviewed Feb 10, 2021
View reviewed changes

Merge branch 'develop' into dependabot/npm_and_yarn/marked-2.0.0
242db94

vercelBotdeployed to Preview February 16, 2021 16:13 View deployment

Merge branch 'develop' into dependabot/npm_and_yarn/marked-2.0.0
9997779

vercelBotdeployed to Preview February 27, 2021 04:52 View deployment

Koooooo-7 added the needs discussion label Feb 27, 2021

sy-records mentioned this pull request Feb 10, 2022
Vulnerable version because of outdated marked version as transitive dependency docsifyjs/docsify-cli#168
Closed

thepiwo mentioned this pull request Feb 21, 2022
remove unused docsify storj-thirdparty/uplink-nodejs#48
Merged

mlms13 mentioned this pull request May 15, 2022
[WIP] Use yarn instead of npm reazen/relude#315
Merged
9 tasks

Koooooo-7 mentioned this pull request Sep 17, 2022
[Dependency Notification] Upgrade marked which may gonna drop support IE11. #1885
Closed

sy-records closed this May 27, 2023

sy-records deleted the dependabot/npm_and_yarn/marked-2.0.0 branch May 27, 2023 05:46

Uh oh!

Uh oh!

Conversation

dependabotBot commented on behalf of githubFeb 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v2.0.0

2.0.0 (2021-02-07)

Bug Fixes

BREAKING CHANGES

Uh oh!

vercelBot commented Feb 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codesandbox-ciBot commented Feb 9, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sy-records left a comment

Choose a reason for hiding this comment

BREAKING CHANGES

Uh oh!

Koooooo-7 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thijstriemstra commented Feb 16, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Koooooo-7 commented Feb 16, 2021

Uh oh!

thijstriemstra commented Feb 26, 2021

Uh oh!

Koooooo-7 commented Feb 27, 2021

Uh oh!

thijstriemstra commented Feb 27, 2021

Uh oh!

Koooooo-7 commented Feb 27, 2021

Uh oh!

klsember commented Mar 10, 2021

Uh oh!

Koooooo-7 commented Mar 11, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Yash-Singh1 commented May 7, 2021

npm audit report

Uh oh!

dependabotBot commented on behalf of githubJan 15, 2022

Uh oh!

Yash-Singh1 commented Jan 15, 2022

Uh oh!

dependabotBot commented on behalf of githubMay 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dependabotBot commented on behalf of githubFeb 9, 2021•
edited
Loading

vercelBot commented Feb 9, 2021•
edited
Loading

codesandbox-ciBot commented Feb 9, 2021•
edited
Loading

Koooooo-7 left a comment •
edited
Loading

thijstriemstra commented Feb 16, 2021•
edited
Loading

Koooooo-7 commented Mar 11, 2021•
edited
Loading