Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 5.8k
refactor: Update test environments and lint configuration#1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
e58b74d27c6592a98ed8fac7652ff7c93c4111841aa5477296e74d8a33488c3a0415af2bc620b5dea79fa8ef92905c2c4b02cff2d7d51edcFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,9 @@ | ||
| .git | ||
| packages/docsify-server-renderer/build.js | ||
| node_modules | ||
| **/*.md | ||
| build | ||
| server.js | ||
| docs | ||
| lib | ||
| node_modules | ||
| packages/docsify-server-renderer/build.js | ||
| server.js | ||
| themes | ||
| build | ||
| docs/ | ||
| **/*.md |
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| *.log | ||
| .DS_Store | ||
| .idea | ||
| __diff_output__ | ||
| lib/ | ||
| *.log | ||
| _playwright-report | ||
| _playwright-results | ||
| lib | ||
| node_modules | ||
| themes/ | ||
| themes | ||
| # exceptions | ||
| !.gitkeep |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| .eslintignore | ||
| .eslintrc | ||
| .github/ | ||
| .github | ||
| .gitignore | ||
| .travis.yml |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| module.exports = { | ||
| arrowParens: 'avoid', | ||
| singleQuote: true, | ||
| trailingComma: 'es5', | ||
| }; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | ||
| "cSpell.words": ["coverpage"] | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the upload-artifact action configuration. Entries in the
pathare zipped and made available for download after all jobs are completed. In this case:_playwright-resultscontains screenshot diffs. We aren't using them yet, but I wanted to have everything ready to go if/when someone wants too._playwright-reportcontains an HTML report of the Playwright set results.Screenshot diffs will only be available when one-or-more screenshot tests fail. The HTML report is generated every test run, but I'm going to update the action configuration to only store artifacts when a failure occurs. We don't need HTML reports filled with green check marks (as satisfying as they may be). :)
Currently, the HTML report is stored even when all tests pass, but I should switch this so
FYI: Artifacts can be downloaded on the bottom of an Action's detail page: