Uh oh!
There was an error while loading. Please reload this page.
Fix the end condition for the embed content handling loop - #1824
Merged
Koooooo-7 merged 8 commits intoMay 18, 2023
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 73dc6d6:
|
julienw added a commit
to julienw/perf.html
that referenced
this pull request
Jun 22, 2022
The fix has been sent upstream in docsifyjs/docsify#1824
julienw added a commit
to julienw/perf.html
that referenced
this pull request
Jun 28, 2022
The fix has been sent upstream in docsifyjs/docsify#1824
julienw added a commit
to julienw/perf.html
that referenced
this pull request
Jun 28, 2022
The fix has been sent upstream in docsifyjs/docsify#1824
julienw added a commit
to julienw/perf.html
that referenced
this pull request
Jun 28, 2022
The fix has been sent upstream in docsifyjs/docsify#1824
julienw
commented
Aug 30, 2022
ContributorAuthor
@sy-records@Koooooo-7 gently ping for this simple patch :-) |
julienw
commented
Dec 13, 2022
ContributorAuthor
up! thanks for your consideration |
julienwforce-pushed
the
fix-non-asynchronous-embeds
branch
from
December 13, 2022 14:48
3bfb1cd to
95f5c45CompareKoooooo-7
approved these changes
Jan 3, 2023
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1822
Summary
This changes (and effectively fixes) the end condition for the embeds handling loop.
What kind of change does this PR introduce?
Bugfix
For any code change,
I didn't see any test related to embed but I'd be happy to update some if needed.
I especially looked at the "embed" page in the documentation, and everything looked good in my opinion.
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
Related issue, if any:
#1822
Tested in the following browsers: