Skip to content

update: enhance the navigating. - #1904

Closed
Koooooo-7 wants to merge 1 commit into
developfrom
enhance-scroll
Closed

update: enhance the navigating.#1904
Koooooo-7 wants to merge 1 commit into
developfrom
enhance-scroll

Conversation

@Koooooo-7

Copy link
Copy Markdown
Member

Summary

Enhance the navigating stuff on sidebar.
When click the same anchor, it won't trigger the hashchange event, even though it already scroll down to other part of content.
close#1899

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

FYI, will add the tests later.

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel

vercelBot commented Oct 7, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewUpdated
docsify-preview✅ Ready (Inspect)Visit PreviewOct 7, 2022 at 9:11PM (UTC)

@Koooooo-7
Koooooo-7 requested a review from a teamOctober 7, 2022 21:12
@codesandbox-ci

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b48ca18:

SandboxSource
docsify-templateConfiguration
muddy-sun-fcsrxhIssue #1899

@Koooooo-7Koooooo-7 added the pinned This is to pinned the PR/Issue in order to keep it open label Oct 26, 2022
@Koooooo-7

Copy link
Copy Markdown
MemberAuthor

After more thoughts on it, This PR needs pending for refine the behavior and concern on active changes actions.
If directly treat all the clink change to trigger hashChangeEvent seems unreasonable.

@trusktr
trusktr marked this pull request as draft January 26, 2023 06:45
@Koooooo-7

Copy link
Copy Markdown
MemberAuthor

closed by #2575

@sy-records
sy-records deleted the enhance-scroll branch July 25, 2025 02:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pinnedThis is to pinned the PR/Issue in order to keep it open

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anchor can't be reused twice

1 participant

@Koooooo-7