Skip to content

fix: fix id with pure number. - #2021

Merged
Koooooo-7 merged 5 commits into
developfrom
fix-id
Apr 22, 2023
Merged

fix: fix id with pure number.#2021
Koooooo-7 merged 5 commits into
developfrom
fix-id

Conversation

@Koooooo-7

Copy link
Copy Markdown
Member

Summary

As per to #2019 mentioned, when the id is pure number, it can not go to the number anchor via id=number directly.
Although it should work in HTML5 which we supported but somehow it still breaks on browser.

close#2019

What kind of change does this PR introduce?

Bugfix

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

@vercel

vercelBot commented Apr 17, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
docsify-preview✅ Ready (Inspect)Visit Preview💬 Add feedbackApr 19, 2023 10:02am

@Koooooo-7
Koooooo-7 requested a review from a teamApril 17, 2023 09:34
@codesandbox-ci

codesandbox-ciBot commented Apr 17, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 747646d:

SandboxSource
docsify-templateConfiguration
gallant-scott-6ih7ugIssue #2019

@Koooooo-7
Koooooo-7 merged commit f4f21a3 into developApr 22, 2023
@sy-records
sy-records deleted the fix-id branch June 19, 2023 01:10
@sy-records
sy-records restored the fix-id branch June 19, 2023 01:10
@sy-records
sy-records deleted the fix-id branch June 19, 2023 01:11
@sy-recordssy-records mentioned this pull request May 5, 2025
@sy-recordssy-records mentioned this pull request Jul 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

waline notification view page doesn't work for docsify

1 participant

@Koooooo-7