Uh oh!
There was an error while loading. Please reload this page.
refactor: move some functions and module-level state into classes as private methods and properties to start to encapsulate Docsify - #2136
Closed
trusktr wants to merge 8 commits into
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
trusktrforce-pushed
the
move-private-functions-properties-into-classes
branch
from
July 17, 2023 04:20
5c49d1e to
2e5787fCompare…private methods and properties to start to encapsulate Docsify Also some small tweaks: - move initGlobalAPI out of Docsify.js to start to encapsulate Docsify - move ajax to utils folder - fix some type definitions and improve content in some JSDoc comments - use concise class field syntax - consolidate duplicate docsify-ignore comment removal code This handles a task in [Simplify and modernize Docsify](#2104), as well as works towards [Encapsulating Docsify](#2135).
trusktrforce-pushed
the
move-private-functions-properties-into-classes
branch
from
July 17, 2023 04:23
2e5787f to
9f8c3c9Compare17 tasks
trusktrforce-pushed
the
move-private-functions-properties-into-classes
branch
from
July 17, 2023 05:56
d7bbb50 to
9f8c3c9Comparetrusktr
commented
Jul 17, 2023
| #enableScrollEvent = true; | ||
| #coverHeight = 0; | ||
| #scrollTo(el, offset = 0) { |
MemberAuthor
There was a problem hiding this comment.
logic was not changed, only moved.
trusktr
commented
Jul 17, 2023
| export function Fetch(Base) { | ||
| let last; | ||
| return class Fetch extends Base { | ||
| #loadNested(path, qs, file, next, vm, first) { |
MemberAuthor
There was a problem hiding this comment.
logic was not changed, only moved.
Koooooo-7
left a comment
Member
There was a problem hiding this comment.
should we change all the _private stuff to #private into ES6? otherwise, it seems messy here with both format.
Koooooo-7
commented
Aug 31, 2023
Member
Closed since no changes detect (weird). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Also some small tweaks:
Related issues
This handles a task in
as well as works towards
Continues from PR
What kind of change does this PR introduce?
Code style update
Refactor
For any code change,
Does this PR introduce a breaking change? (check one)
No
If yes, please describe the impact and migration path for existing applications:
Tested in the following browsers: