Uh oh!
There was an error while loading. Please reload this page.
fix: dev mode hot reload and add sourcemaps - #2402
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
sy-records
approved these changes
Apr 13, 2024
jhildenbiddle
commented
Apr 15, 2024
MemberAuthor
@Koooooo-7 -- Awaiting approval to merge PR. Thx! |
Koooooo-7
approved these changes
Apr 17, 2024
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two development issues:
lib/docsify.min.jswhich was only updated on "production" builds. The build now generates minified and non-minified bundles for all builds..min.jsfiles in/lib/. This solution is best for troubleshooting during development because source maps provide unminified source code along with accurate file and line locations on errors. Using non-minified bundles for development was previously discussed, however this approach does not provide accurate source file and line locations.Related issue, if any:
None
What kind of change does this PR introduce?
Bugfix
Build-related changes
For any code change,
N/A
Does this PR introduce a breaking change?
No
Tested in the following browsers: