Skip to content

Remove dead code in getNode Vue detection - #2631

Merged
trusktr merged 2 commits into
type-definitionsfrom
copilot/sub-pr-2392-again
Nov 18, 2025
Merged

Remove dead code in getNode Vue detection#2631
trusktr merged 2 commits into
type-definitionsfrom
copilot/sub-pr-2392-again

Conversation

CopilotAI commented Nov 18, 2025

Copy link
Copy Markdown

Summary

Removed dead code line window.Vue.version; in src/core/util/dom.js. The property access served no purpose and was flagged during code review.

 export function getNode(el, noCache = false) {
if (typeof el === 'string') {
if (typeof window.Vue !== 'undefined') {
- window.Vue.version;
return find(el);
}

Related issue, if any:

#2392

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel

vercelBot commented Nov 18, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentPreviewCommentsUpdated (UTC)
docsify-previewErrorErrorNov 18, 2025 0:49am

Co-authored-by: trusktr <297678+trusktr@users.noreply.github.com>

CopilotAI commented Nov 18, 2025

Copy link
Copy Markdown
Author

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.google.com
    • Triggering command: node /home/REDACTED/work/docsify/docsify/node_modules/.bin/jest --selectProjects unit (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

CopilotAI changed the title [WIP] Fix output type definitions by removing specified lineRemove dead code in getNode Vue detectionNov 18, 2025
CopilotAI requested a review from trusktrNovember 18, 2025 00:51
@trusktr
trusktr marked this pull request as ready for review November 18, 2025 01:14
@trusktr
trusktr merged commit dedc3b8 into type-definitionsNov 18, 2025
2 of 3 checks passed
@trusktr
trusktr deleted the copilot/sub-pr-2392-again branch November 18, 2025 01:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@trusktr