Uh oh!
There was an error while loading. Please reload this page.
feat: allows relative path, fixed #590 - #714
Conversation
timaschew
commented
Jan 12, 2019
Any plans to merge this PR (before 5.0)? |
sansnom
commented
Jan 30, 2019
@timaschew any plan to merge this one ? :) |
timaschew
commented
Jan 30, 2019
@sansnom I've created today a PR (not merged yet) providing a test environment in order to verify that we don't introduce new bugs when changing anything. Would be nice if we can have some tests for this feature as well. If you |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sansnom
commented
Mar 28, 2019
Anyone to recheck and merge this ? :) I've added some unit test. Thanks ! |
timaschew
commented
Mar 29, 2019
sansnom
commented
Apr 3, 2019
@timaschew Glad to see #603 has been resolved and the project can continue. :) |
timaschew
commented
Apr 5, 2019
@sansnom sorry for the delay. I will merge it this weekend. |
Hello,
It's the same PR as #593 thanks to @NoCLin which allows relative path (fix#590). But I've added an option relativePath to enable it (like proposed in #657). By default it's disabled so it's backward compatible: no breaking changes. :)
I've tried to add some documentation, I hope it's clear enough.
Please makes sure these boxes are checked before submitting your PR, thank you!
masterbranch.libdirectory.