Fix #791 by aenniw · Pull Request #866 · docsifyjs/docsify

aenniw · 2019-06-08T15:39:18Z

Signed-off-by: Martin Mihálek aenniw@gmail.com

Summary

Fixed out of orded embedding of include files

What kind of change does this PR introduce? (check at least one)

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

Yes
No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

If adding a new feature, the PR's description includes:

A convincing reason for adding this feature
Related documents have been updated
Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

DO NOT include files inside lib directory.

aenniw · 2019-07-06T10:35:51Z

Addresses #791

stale · 2020-02-04T07:37:23Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

anikethsaha · 2020-02-05T17:30:15Z

@aenniw please rebase and resolve the conflicts.
also change the commit message. make it more detailed in order to fit better for changlog

…order, see docsifyjs/docsify#866)

anikethsaha · 2020-02-23T19:24:19Z

can you resolve the conflicts

aenniw · 2020-02-23T22:10:10Z

Rebased, however not sure whats Security Flow about...

trusktr

Thanks for attempting to fix this! Let's make sure

current tests pass (I suppose this just requires fixing the conflict)
add new tests that ensure multiple embeds work as we're expecting

aenniw · 2020-04-09T07:37:21Z

Not sure how to approach the tests, as It occurs only when embedded files are downloaded out of order mainly due their size difference and network delay...
On local server setup despite big difference in embedded file sizes only way how to partially reproduce the issue is with throttling in browser...

aenniw · 2020-04-10T09:08:05Z

Added e2e scenario and updated live-server to delay serving of one of embedded files to replicate the issue...

anikethsaha

thanks for the update. few notes

Koooooo-7

yea, per to the docs, failureThreshold should be changed to smaller.
and I thing It is not a good way that showing test cases on the documentation, it makes users messy.

anikethsaha · 2020-04-10T15:24:05Z

I agree with @Koooooo-7 , we cant show testing fixture in docs.
@aenniw can you make those files just for the testing. try added script here.
that file is copy-pasting content from the original docs. so after the copy-pasting, you can add function to create a file and write the content as you need or in some other way whichever you prefer.
I know its a bit of extra work but we don't have strong test. and the issue addressing in this PR is quite common we noticed in chats. so it would be great to have a good setup and it will help in reviewing this better

aenniw · 2020-05-11T16:00:50Z

Extracted test specific blocks from docs, updated cypress setup.js to inline content before predefined tag

jthegedus · 2020-05-12T01:48:22Z

Looking good

anikethsaha

looks good to me.
can you fix the CI and we are good to go.

- added double quote as attribute marker - fixed inject order of embedded files - added e2e test covering order of embedded files

aenniw · 2020-05-12T17:10:21Z

CI fixed by updating reference img as new lines were added to docs via PR and it wasn't updated...

trusktr · 2022-01-12T05:36:40Z

Unfortunately (or fortunately, depending on your view) the test system changed from cypress to playwright, making a lot of conflicts in the PR. We need to update this to playwright.

trusktr

needs conflicts resolved, moving from cypress to playwright.

sy-records · 2025-07-24T09:35:53Z

There are too many conflicts, so it is temporarily closed.

staleBot added the wontfix label Feb 4, 2020

anikethsaha requested a review from trusktr February 4, 2020 08:13

staleBot removed the wontfix label Feb 4, 2020

anikethsaha added the pinned This is to pinned the PR/Issue in order to keep it open label Feb 4, 2020

anikethsaha self-assigned this Feb 5, 2020

anikethsaha requested a review from a teamFebruary 5, 2020 18:37

alexis- added a commit to supermemo-wiki/docsify that referenced this pull request Feb 8, 2020
- Implemented aenniw'sfixdocsifyjs#866
7291a06

alexis- added a commit to supermemo-wiki/SuperMemoAssistant.Wiki that referenced this pull request Feb 8, 2020
- Temporarily fallback to local docsify (fixed includes being out of …
5f44443
…order, see docsifyjs/docsify#866)

aenniw closed this Feb 23, 2020

aenniw deleted the bug/791 branch February 23, 2020 19:22

aenniw restored the bug/791 branch February 23, 2020 19:23

aenniw reopened this Feb 23, 2020

aenniw force-pushed the bug/791 branch from bbf74a3 to 4fcde59Compare February 23, 2020 21:53

anikethsaha closed this Feb 25, 2020

anikethsaha reopened this Feb 25, 2020

randName mentioned this pull request Mar 17, 2020
Embed with :type=code replacing entire page when other embeds are present #1078
Closed
1 task

trusktr requested changes Apr 3, 2020
View reviewed changes

aenniw force-pushed the bug/791 branch from 4fcde59 to 7cca1edCompare April 7, 2020 18:05

aenniw force-pushed the bug/791 branch from 7cca1ed to 384227aCompare April 10, 2020 08:57

aenniw force-pushed the bug/791 branch from 384227a to f7a217dCompare April 10, 2020 09:09

anikethsaha requested changes Apr 10, 2020
View reviewed changes

Comment threadcypress/support/commands.js
Comment threaddocs/_media/delayed.md
Comment threaddocs/_media/non-delayed.md

anikethsaha requested review from a team and removed request for a teamApril 10, 2020 09:26

anikethsaha requested review from Koooooo-7 and trusktr April 10, 2020 09:26

Koooooo-7 reviewed Apr 10, 2020
View reviewed changes

Comment threaddocs/embed-files.md

aenniw force-pushed the bug/791 branch from f7a217d to d9b80cfCompare May 11, 2020 15:56

aenniw requested a review from anikethsaha May 11, 2020 20:26

anikethsaha requested changes May 12, 2020
View reviewed changes

anikethsaha requested a review from Koooooo-7 May 12, 2020 05:24

aenniw force-pushed the bug/791 branch 2 times, most recently from d94db2b to 5770badCompare May 12, 2020 16:58

Fix out of order embedding of files
661a702
- added double quote as attribute marker - fixed inject order of embedded files - added e2e test covering order of embedded files

aenniw force-pushed the bug/791 branch from 5770bad to 661a702Compare May 12, 2020 17:03

anikethsaha approved these changes May 12, 2020
View reviewed changes

trusktr requested changes Jan 12, 2022
View reviewed changes

sy-records mentioned this pull request Oct 30, 2022
[Snyk] Upgrade debug from 4.3.3 to 4.3.4 #1919
Merged

sy-records closed this Jul 24, 2025

Uh oh!

Uh oh!

Conversation

aenniw commented Jun 8, 2019

Uh oh!

aenniw commented Jul 6, 2019

Uh oh!

staleBot commented Feb 4, 2020

Uh oh!

anikethsaha commented Feb 5, 2020

Uh oh!

anikethsaha commented Feb 23, 2020

Uh oh!

aenniw commented Feb 23, 2020

Uh oh!

trusktr left a comment

Choose a reason for hiding this comment

Uh oh!

aenniw commented Apr 9, 2020

Uh oh!

aenniw commented Apr 10, 2020

Uh oh!

anikethsaha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Koooooo-7 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

anikethsaha commented Apr 10, 2020

Uh oh!

aenniw commented May 11, 2020

Uh oh!

jthegedus commented May 12, 2020

Uh oh!

anikethsaha left a comment

Choose a reason for hiding this comment

Uh oh!

aenniw commented May 12, 2020

Uh oh!

trusktr commented Jan 12, 2022

Uh oh!

trusktr left a comment

Choose a reason for hiding this comment

Uh oh!

sy-records commented Jul 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants