Skip to content

Fix #865 - #867

Merged
anikethsaha merged 1 commit into
docsifyjs:developfrom
aenniw:bug/865
Mar 9, 2020
Merged

Fix #865#867
anikethsaha merged 1 commit into
docsifyjs:developfrom
aenniw:bug/865

Conversation

@aenniw

@aenniwaenniw commented Jun 8, 2019

Copy link
Copy Markdown
Contributor

fixes#865

Signed-off-by: Martin Mihálek aenniw@gmail.com

Summary

Added relative to absolute path resolving in embeded mardown files for links like so:

[file.txt](./file.txt)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 74.0.3729.169
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

@aenniw

Copy link
Copy Markdown
ContributorAuthor

Addresses #865

@anikethsaha

Copy link
Copy Markdown
Member

We need to add tests first in this project then we will check if it's breaking or conflicting any other links

@dellagustin-sap

Copy link
Copy Markdown

Hi all, I am also experiencing this issue.
For taking our own decision on whether to document a workaround in the page our trying to apply a fix (that would introduce for us technical debt), I would like to ask if an estimated timeframe for integrating this PR could be provided.

BR,
Guilherme.

@anikethsaha

Copy link
Copy Markdown
Member

@aenniw please rebase and resolve the conflicts.
also change the commit message. make it more detailed in order to fit better for changlog

@anikethsahaanikethsaha self-assigned this Feb 5, 2020

@anikethsahaanikethsaha left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase to run the tests.
else it looks good to me

@anikethsahaanikethsaha removed their assignment Feb 5, 2020
@anikethsahaanikethsaha self-assigned this Feb 14, 2020
@aenniw
aenniwforce-pushed the bug/865 branch 2 times, most recently from d55c5ba to 14c0688CompareFebruary 23, 2020 21:53
Signed-off-by: Martin Mihálek <aenniw@gmail.com>
@aenniw

Copy link
Copy Markdown
ContributorAuthor

Rebased

@anikethsaha
anikethsaha merged commit 291c99b into docsifyjs:developMar 9, 2020
@Jack-Works

Jack-Works commented Mar 28, 2020

Copy link
Copy Markdown

Still happened in 4.11.2, example: links in https://jack-works.github.io/bayesian-conspiracy/#/./projects/2019/holoflows-kit.md

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded files doesn't resolve relative links

6 participants

@aenniw@anikethsaha@dellagustin-sap@Jack-Works@timaschew@jhildenbiddle