Replace controllers with handlers

[marioradu05]

No description provided.

[github-actions]

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 114 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency	Version	Licenses
brick/math	0.12.3	MIT
brick/varexporter	0.6.0	MIT
composer/ca-bundle	1.5.5	MIT
doctrine/collections	2.2.2	MIT
doctrine/common	3.5.0	MIT
doctrine/data-fixtures	2.0.2	MIT
doctrine/dbal	4.2.2	MIT
doctrine/deprecations	1.1.4	MIT
doctrine/event-manager	2.0.1	MIT
doctrine/inflector	2.0.10	MIT
doctrine/instantiator	2.0.0	MIT
doctrine/lexer	3.0.1	MIT
doctrine/migrations	3.8.2	MIT
doctrine/orm	3.3.2	MIT
doctrine/persistence	4.0.0	MIT
dotkernel/dot-authentication	2.6.0	MIT
dotkernel/dot-authorization	3.7.0	MIT
dotkernel/dot-cache	4.3.0	MIT
dotkernel/dot-cli	3.9.0	MIT
dotkernel/dot-controller	3.5.1	MIT
dotkernel/dot-data-fixtures	1.4.0	MIT
dotkernel/dot-dependency-injection	1.2.0	MIT
dotkernel/dot-errorhandler	4.0.0	MIT
dotkernel/dot-event	3.4.2	MIT
dotkernel/dot-flashmessenger	3.5.0	MIT
dotkernel/dot-geoip	3.9.0	MIT
dotkernel/dot-helpers	3.7.1	MIT
dotkernel/dot-log	4.0.4	MIT
dotkernel/dot-mail	5.1.5	MIT
dotkernel/dot-navigation	3.5.1	MIT
dotkernel/dot-rbac-guard	3.5.0	MIT
dotkernel/dot-rbac	3.6.0	MIT
dotkernel/dot-session	5.6.0	MIT
dotkernel/dot-twigrenderer	3.4.3	MIT
egulias/email-validator	4.0.3	MIT
fig/http-message-util	1.1.5	MIT
friendsofphp/proxy-manager-lts	v1.0.18	MIT
geoip2/geoip2	v3.1.0	Apache-2.0
guzzlehttp/guzzle	7.9.2	MIT
guzzlehttp/promises	2.0.4	MIT
guzzlehttp/psr7	2.7.0	MIT
laminas/laminas-authentication	2.16.0	BSD-3-Clause
laminas/laminas-cli	1.11.0	BSD-3-Clause
laminas/laminas-code	4.16.0	BSD-3-Clause
laminas/laminas-component-installer	3.5.0	BSD-3-Clause
laminas/laminas-config-aggregator	1.18.0	BSD-3-Clause
laminas/laminas-diactoros	3.5.0	BSD-3-Clause
laminas/laminas-escaper	2.16.0	BSD-3-Clause
laminas/laminas-eventmanager	3.14.0	BSD-3-Clause
laminas/laminas-filter	2.40.0	BSD-3-Clause
laminas/laminas-form	3.21.0	BSD-3-Clause
laminas/laminas-httphandlerrunner	2.11.0	BSD-3-Clause
laminas/laminas-hydrator	4.16.0	BSD-3-Clause
laminas/laminas-i18n	2.29.0	BSD-3-Clause
laminas/laminas-inputfilter	2.31.0	BSD-3-Clause
laminas/laminas-json	3.7.1	BSD-3-Clause
laminas/laminas-math	3.8.1	BSD-3-Clause
laminas/laminas-permissions-rbac	3.7.0	BSD-3-Clause
laminas/laminas-servicemanager	3.23.0	BSD-3-Clause
laminas/laminas-session	2.24.0	BSD-3-Clause
laminas/laminas-stdlib	3.20.0	BSD-3-Clause
laminas/laminas-stratigility	3.13.0	BSD-3-Clause
laminas/laminas-translator	1.1.0	BSD-3-Clause
laminas/laminas-validator	2.64.2	BSD-3-Clause
laminas/laminas-view	2.36.0	BSD-3-Clause
maxmind-db/reader	v1.12.0	Apache-2.0
maxmind/web-service-common	v0.10.0	Apache-2.0
mezzio/mezzio-authentication	1.10.0	BSD-3-Clause
mezzio/mezzio-authorization-rbac	1.8.0	BSD-3-Clause
mezzio/mezzio-authorization	1.10.0	BSD-3-Clause
mezzio/mezzio-cors	1.13.0	BSD-3-Clause
mezzio/mezzio-fastroute	3.12.0	BSD-3-Clause
mezzio/mezzio-helpers	5.17.0	BSD-3-Clause
mezzio/mezzio-router	3.18.0	BSD-3-Clause
mezzio/mezzio-template	2.11.0	BSD-3-Clause
mezzio/mezzio-twigrenderer	2.17.0	BSD-3-Clause
mezzio/mezzio	3.20.1	BSD-3-Clause
nikic/fast-route	v1.3.0	BSD-3-Clause
nikic/php-parser	v5.4.0	BSD-3-Clause
psr/cache	3.0.0	MIT
psr/container	1.1.2	MIT
psr/event-dispatcher	1.0.0	MIT
psr/http-client	1.0.3	MIT
psr/http-factory	1.1.0	MIT
psr/http-message	2.0	MIT
psr/http-server-handler	1.0.2	MIT
psr/http-server-middleware	1.0.2	MIT
psr/log	3.0.2	MIT
ralouphie/getallheaders	3.0.3	MIT
ramsey/collection	2.1.0	MIT
ramsey/uuid-doctrine	2.1.0	MIT
ramsey/uuid	4.7.6	MIT
roave/psr-container-doctrine	5.7.0	BSD-2-Clause
symfony/cache-contracts	v3.5.1	MIT
symfony/cache	v7.2.4	MIT
symfony/console	v7.2.1	MIT
symfony/deprecation-contracts	v3.5.1	MIT
symfony/event-dispatcher-contracts	v3.5.1	MIT
symfony/event-dispatcher	v7.2.0	MIT
symfony/filesystem	v7.2.0	MIT
symfony/mailer	v7.2.3	MIT
symfony/mime	v7.2.4	MIT
symfony/polyfill-ctype	v1.31.0	MIT
symfony/polyfill-intl-grapheme	v1.31.0	MIT
symfony/polyfill-intl-idn	v1.31.0	MIT
symfony/polyfill-intl-normalizer	v1.31.0	MIT
symfony/polyfill-mbstring	v1.31.0	MIT
symfony/service-contracts	v3.5.1	MIT
symfony/stopwatch	v7.2.4	MIT
symfony/string	v7.2.0	MIT
symfony/var-exporter	v7.2.4	MIT
twig/twig	v3.20.0	BSD-3-Clause
webimpress/safe-writer	2.2.0	BSD-2-Clause
webmozart/assert	1.11.0	MIT

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[alexmerlin]

Extending on @arhimede's patterns, I tried to come up with a generic pattern that would fit all handlers.
See my suggestions in the below table:

Module	Verb	Resource	Action	Extra	Handler	Handler directory/file name	Route path	Route name
Admin	Get	Admin	Create	Form	Handler	Admin/GetAdminCreateFormHandler	/admin/create-admin	admin::admin-create-form
Admin	Post	Admin	Create		Handler	Admin/PostAdminCreateHandler	/admin/create-admin	admin::admin-create
Admin	Get	Admin	Edit	Form	Handler	Admin/GetAdminEditFormHandler	/admin/edit-admin/{uuid}	admin::admin-edit-form
Admin	Post	Admin	Edit		Handler	Admin/PostAdminEditHandler	/admin/edit-admin/{uuid}	admin::admin-edit
Admin	Get	Admin	Delete	Form	Handler	Admin/GetAdminDeleteFormHandler	/admin/delete-admin/{uuid}	admin::admin-delete-form
Admin	Post	Admin	Delete		Handler	Admin/PostAdminDeleteHandler	/admin/delete-admin/{uuid}	admin::admin-delete
Admin	Get	Admin	List		Handler	Admin/GetAdminListHandler	/admin/list-admin	admin::admin-list
Admin	Get	AdminLogin	List		Handler	Admin/GetAdminLoginListHandler	/admin/list-admin-login	admin::admin-login-list
Admin	Get	AdminAccount	Edit	Form	Handler	Account/GetAccountEditFormHandler	/admin/edit-account	admin::account-edit-form
Admin	Post	AdminAccount	Edit		Handler	Account/PostAccountEditHandler	/admin/edit-account	admin::account-edit
Admin	Post	AdminAccount	ChangePassword		Handler	Account/PostAccountChangePasswordHandler	/admin/edit-account	admin::account-change-password
Admin	Get	AdminAccount	Login	Form	Handler	Account/GetAccountLoginFormHandler	/admin/login	admin::admin-login-form
Admin	Post	AdminAccount	Login		Handler	Account/PostAccountLoginHandler	/admin/login	admin::admin-login
Admin	Get	AdminAccount	Logout		Handler	Account/GetAccountLogoutHandler	/admin/logout	admin::admin-logout
App	Get	Index	Redirect		Handler	GetIndexRedirectHandler	/	app::index-redirect
Dashboard	Get	Dashboard	View		Handler	GetDashboardViewHandler	/dashboard	dashboard::dashboard-view
Page	Get	Page	View		Handler	GetPageViewHandler	/page/component	page::components
Setting	Get	Setting	View		Handler	GetSettingViewHandler	/setting/{identifier}	setting::setting-view
Setting	Post	Setting	Store		Handler	PostSettingStoreHandler	/setting/{identifier}	setting::setting-store
User	Get	User	Create	Form	Handler	GetUserCreateFormHandler	/user/create-user	user::user-create-form
User	Post	User	Create		Handler	PostUserCreateHandler	/user/create-user	user::user-create
User	Get	User	Delete	Form	Handler	GetUserDeleteFormHandler	/user/delete-user/{uuid}	user::user-delete-form
User	Post	User	Delete		Handler	PostUserDeleteHandler	/user/delete-user/{uuid}	user::user-delete
User	Get	User	Edit	Form	Handler	GetUserEditFormHandler	/user/edit-user/{uuid}	user::user-edit-form
User	Post	User	Edit		Handler	PostUserEditHandler	/user/edit-user/{uuid}	user::user-edit
User	Get	User	List		Handler	GetUserListHandler	/user/list-user	user::user-list
User	Post	UserAvatar	Edit		Handler	PostUserAvatarEditHandler	/user/edit-user-avatar/{uuid}	user::user-avatar-edit

I know that introducing a few days ago the terms Resource and Collection was my idea, and now I'm dropping them, but while making the above table, they did not seem to make sense anymore.
The action View might sound MVC-ish, so if needed, it might be replaced with something more suitable.

Note that the route names also follow the same pattern:

module::resource-action-{form}

[alexmerlin]

Maybe a more readable form of the same table from my previous comment:

[alexmerlin]

@MarioRadu Try replacing dotkernel/dot-rbac-guard with dotkernel/dot-rbac-route-guard and let me know if you encounter any issues with the new package.

[arhimede]

@alexmerlin please merge when you think in branch 6
will not have an V 6 release anyway

[alexmerlin]

We should rename add-admin-modal-content.html.twig to create-admin-modal-content.html.twig, just to match the naming pattern from GetAdminCreateFormHandler. (create vs add)

Or, maybe create-admin-form.html.twig?
If so, the all three *-admin-modal-content.html.twig templates should be called *-admin-form.html.twig

---

Let's also replace all occurrences of DotKernel with Dotkernel

[alexmerlin]

Pagination is broken.

[alexmerlin]

Navigation does not reflect current page.

[alexmerlin]

Table contents are not displayed if an admin does not have column settings for a specific table.

[arhimede]

thanks @MarioRadu