Skip to content

Chapter 2 code - #12

Draft
Howriq wants to merge 14 commits into
chapter-1from
chapter-2
Draft

Chapter 2 code#12
Howriq wants to merge 14 commits into
chapter-1from
chapter-2

Conversation

@Howriq

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
@Howriq

Howriq commented Nov 25, 2025

Copy link
Copy Markdown
MemberAuthor

This is the functional code for chapter 2. I want to call it "Migrations and Entities".

Maybe I can remove a couple of files, for example TimestampsTrait.php. The tutorial might get overcrowded otherwise.
I could also add it as a good practice 😉

@arhimede

Copy link
Copy Markdown
Member

what about all those failed actions ?

@Howriq

Copy link
Copy Markdown
MemberAuthor

what about all those failed actions ?

They are mainly from:

  • doctrine migration line being too long,
  • type docs which we said would cover in a different tutorial
  • the main README which is very chaotic

@arhimede

Copy link
Copy Markdown
Member

what about all those failed actions ?

They are mainly from:

* doctrine migration line being too long,
* type docs which we said would cover in a different tutorial
* the main README which is very chaotic

It is not relevant the cause
I am expecting to be fixed and see green all over the place

Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>

@alexmerlinalexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this supposed to stay on its own branch?
Because I see that you try to merge chapter-2 into chapter-1 - or you did this only so that we can see the differences between the two branches, without the intention to merge them.

Comment threadsrc/Book/src/Entity/Book.php Outdated
Comment threadsrc/Book/src/Entity/Book.php Outdated
Comment threadsrc/App/src/Entity/TimestampsTrait.php Outdated
Comment threadsrc/App/src/Entity/UuidIdentifierTrait.php Outdated
Comment threadsrc/App/src/Entity/AbstractEntity.php Outdated
Comment threadsrc/Migrations/Version20251125173634.php Outdated
Comment threaddata/cache/.gitignore
Comment threadsrc/App/src/ConfigProvider.php Outdated
Comment threadsrc/App/src/ConfigProvider.php Outdated
Comment threadsrc/App/src/ConfigProvider.php Outdated
Comment threadsrc/Book/src/Entity/Book.php
Signed-off-by: Howriq <horea@rospace.com>
Comment threadphpcs.xml Outdated
Comment threadsrc/Migrations/.gitkeep Outdated
Comment threadREADME.md
Comment threadsrc/App/src/ConfigProvider.php Outdated
Comment threadsrc/App/src/Entity/AbstractEntity.php
Comment threadsrc/App/src/Resolver/EntityListenerResolver.php Outdated
Comment threadsrc/App/src/DBAL/Types/UuidType.php
Comment threadsrc/Book/src/Entity/Book.php Outdated
Comment threadsrc/Book/src/Entity/Book.php Outdated
Comment threadsrc/Book/src/Entity/Book.php Outdated
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
@Howriq

Copy link
Copy Markdown
MemberAuthor

I presume that you found that this file is required even without the upload avatar feature I mentioned.
That's why you did not delete it?
Please confirm.

That file was no longer required. I have removed it.

@alexmerlinalexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more items and it's good to go...

Comment threadsrc/Book/src/Entity/Book.php
Comment threadsrc/Book/src/Entity/Book.php
Comment threadsrc/App/src/ConfigProvider.php Outdated
Signed-off-by: Howriq <horea@rospace.com>
Signed-off-by: Howriq <horea@rospace.com>
@alexmerlin
alexmerlin marked this pull request as draft November 27, 2025 10:20
Howriqand others added 2 commits December 9, 2025 20:07
Signed-off-by: Howriq <horea@rospace.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Howriq@arhimede@alexmerlin