Skip to content

An input implementation using GLFW - #21

Merged
Perksey merged 53 commits into
masterfrom
glfw-input
Aug 4, 2019
Merged

An input implementation using GLFW#21
Perksey merged 53 commits into
masterfrom
glfw-input

Conversation

@Perksey

@PerkseyPerksey commented Jul 14, 2019

Copy link
Copy Markdown
Member

Summary of the PR

Implements Silk.NET.Input.Desktop.

Related issues, Discord discussions, or proposals

https://github.com/Ultz/Silk.NET/blob/master/documentation/proposals/Proposal%20-%20Input.md

Further Comments

@PerkseyPerksey changed the title An input implementation using GLFW[WIP] An input implementation using GLFWJul 14, 2019
devvoid
devvoid reviewed Jul 15, 2019
View reviewed changes
Comment threadsrc/Input/Silk.NET.Input.Desktop/Util.cs Outdated
devvoidand others added 26 commits July 19, 2019 15:50
@devvoid@Perksey
Additional work on GLFW input (#26)
e633f36
* Move ApplyDeadzone to Deadzone struct
* Add test program, move ConnectionChanged to IInputContext
* Add functionality to test program
@Perksey
Merge branch 'master' into glfw-input
2f87960
@Perksey
More input work
f80cba2
@Perksey
Add an .editorconfig
a1f6a27
@frederikja163
ThumbstickCollection
8dcc3f1
@frederikja163
ButtonCollection
92f9f68
@frederikja163
Hat and Trigger collection
4503a97
@frederikja163
Update collections
2859bdf
@frederikja163
joystick axis cache
422c2f4
@frederikja163
Update cached axis
3cdcc40
@Perksey
Update GlfwJoystick.cs
0046628
@frederikja163
Joystick cache
e0702c0
@frederikja163
Merge remote-tracking branch 'Ultz/glfw-input' into glfw-input
1dc18db
@Perksey
Merge remote-tracking branch 'origin/glfw-input' into glfw-input
dae0f11
@frederikja163
AxisCollection
958818b
@frederikja163
GamePad and Joystick cache
dcb02c6
@frederikja163
Merge remote-tracking branch 'Ultz/glfw-input' into glfw-input
d334135
@frederikja163
GamepadFix
f159b8c
@frederikja163
GamePad Updates
213c760
@frederikja163
Bracket fix
a946ba2
@Perksey
work
d9d0cae
@frederikja163
Thumbstick update
85042ab
@frederikja163
Gamepad implementation
4cb7095
@Perksey
nitpick
b4fe961
@Perksey
merge
03e6969
@Perksey
update test program
652450e
Perkseyand others added 19 commits August 1, 2019 00:21
@Perksey
Only show window when running
436c4f1
@Perksey
Fix context not being passed to enumerator
f130cda
@Perksey
Fix a marshalling bug
2ceb2f2
@Perksey
Apply deadzone
013f410
@Perksey
Enumerate over the disconnected joysticks too.
1658f44
@Perksey
Update the test app.
8083807
@frederikja163
Controller events fix
bec0f33
@Perksey
wip
fe823d6
@Perksey
Use indexers on the pointers
abdb81a
@Perksey
Fix mismatched enumerant names in GLFW
2220a7b
@Perksey
Destroy window when we're done
3c83428
@Perksey
Fix wrong enum values in GLFW
32f385f
@Perksey
Make properties update initialOptions, and only invoke GLFW if running
8ddba81
@Perksey
Window is immovable when only 1 thread is used, investigate WindowUpdate
911d42c
@john-h-k@Perksey
FixGetmethods (#30)
5ae7fc1
* Fix the abominations that were `Get()` methods
* Remove Get methods entirely
@Perksey
Merge branch 'master' into glfw-input
3fba09b
@Perksey
Merge branch 'master' into glfw-input
71a5bd8
@Perksey
Fully implement mice, fix deadlock issues
0b90dad
@Perksey
This is GLFW input.
b0c82f2
@PerkseyPerksey changed the title [WIP] An input implementation using GLFWAn input implementation using GLFWAug 3, 2019
@Perksey
Perksey requested a review from a teamAugust 3, 2019 23:10
frederikja163
frederikja163 approved these changes Aug 4, 2019
View reviewed changes

@frederikja163frederikja163 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things, just looked generally over everything. Should be preview 1 ready, but there are some small things that could/should be adressed before release

Comment threadsrc/Input/Silk.NET.Input.Desktop/GlfwInputPlatform.cs
Comment threadsrc/Input/Silk.NET.Input.Desktop/GlfwInputContext.cs Outdated
Comment threadsrc/Input/Silk.NET.Input.Desktop/InputHandler.cs Outdated
@Perksey
Perksey merged commit f17ca05 into masterAug 4, 2019
@Perksey
Perksey deleted the glfw-input branch August 4, 2019 16:23
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@devvoiddevvoiddevvoid left review comments
@frederikja163frederikja163frederikja163 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Input

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Perksey@frederikja163@devvoid@john-h-k