Skip to content

[3.0] Improve handling of Khronos enum native names - #2534

Merged
Exanite merged 11 commits into
dotnet:develop/3.0from
Exanite:fix/incorrect-native-name-glenum
Jan 30, 2026
Merged

[3.0] Improve handling of Khronos enum native names#2534
Exanite merged 11 commits into
dotnet:develop/3.0from
Exanite:fix/incorrect-native-name-glenum

Conversation

@Exanite

@ExaniteExanite commented Jan 12, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary of the PR

This changes the native name for namespaced enums like GLEnum to be GLenum.
In the process, I also found a bug where Vulkan enums had inconsistent native names.

Related issues, Discord discussions, or proposals

Discord conversation: https://discord.com/channels/521092042781229087/587346162802229298/1460042806952198310
PR where this issue was first discovered: #2503

This PR contains the following sub-PR:

Further Comments

N/A

@ExaniteExanite changed the title Improve handling of Khronos enum native names[3.0] Improve handling of Khronos enum native namesJan 12, 2026
Exanite
Exanite commented Jan 12, 2026
View reviewed changes

@ExaniteExanite left a comment

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review complete. Marking as ready for review and subsequent merge.

Comment threadsources/Vulkan/Vulkan/Enums/DataGraphPipelineDispatchFlagsARM.gen.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs Outdated
Comment threadtests/SilkTouch/SilkTouch/Khronos/MixKhronosDataTests.cs Outdated
Comment threadtests/SilkTouch/SilkTouch/Khronos/MixKhronosDataTests.cs
Comment threadsources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs Outdated
@Exanite
Exanite marked this pull request as ready for review January 12, 2026 11:02
@Exanite
Exanite requested a review from a team as a code ownerJanuary 12, 2026 11:02
Perksey
Perksey reviewed Jan 12, 2026
View reviewed changes
Comment threadsources/SilkTouch/SilkTouch/Mods/MixKhronosData.cs Outdated
@Exanite
Exanite requested a review from PerkseyJanuary 13, 2026 00:01
@ExaniteExanite mentioned this pull request Jan 13, 2026
Merged
7 tasks
@Exanite
Exanite marked this pull request as draft January 14, 2026 02:55
@ExaniteExanite mentioned this pull request Jan 15, 2026
Merged
@Exanite

Exanite commented Jan 15, 2026

Copy link
Copy Markdown
MemberAuthor

This PR will be ready for review/merge once Exanite#30 is merged into this PR.

@Exanite
Merge pull request#30from Exanite/fix/missing-flags-attr-on-certain…
7e1f405
…-enums
[3.0] Fix missings [Flags] attribute on certain OpenGL enums; Require explicit typemap for enum base types
@Exanite
Exanite marked this pull request as ready for review January 21, 2026 22:13
@Exanite
Exanite enabled auto-merge (squash) January 30, 2026 19:43
@Exanite
Exanite merged commit 7a5299e into dotnet:develop/3.0Jan 30, 2026
11 checks passed
@Exanite
Exanite deleted the fix/incorrect-native-name-glenum branch January 30, 2026 19:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curincurincurin approved these changes
@PerkseyPerkseyAwaiting requested review from Perksey

Assignees

No one assigned

Labels

None yet

Projects

Silk.NET Development Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Exanite@curin@Perksey