Uh oh!
There was an error while loading. Please reload this page.
docs: fix broken source-file links in managed chaining intro - #2579
Merged
Conversation
The opening paragraph of `documentation/vulkan/structure-chaining/managed-chaining.md` linked to source files via repo-relative paths (e.g. `../../src/Vulkan/...`). On the rendered docs site these resolve to `/Silk.NET/docs/src/...`, which does not exist, so all three links 404. Two of the targets were also renamed during 3.0 work: `Chain.gen.tt` is now `Chain.g.tt`, and `Chain.gen.cs` is now `Chain.g.cs`. Switch the three links to absolute GitHub URLs pointing at the current file paths on `main`. Fixesdotnet#2566
Exanite
approved these changes
May 12, 2026
Exanite
left a comment
Member
There was a problem hiding this comment.
Looks good to me. I'll ping another maintainer to review it tomorrow and get this merged.
I also investigated a bit on my end and it looks like this is the correct way to go about it. Using relative links is messy considering how the website is built (I believe it's built from the 3.0 branch) and apparently leads to the file being downloaded instead, which isn't great.
mokashang
commented
May 12, 2026
via email
ContributorAuthor
Thanks for the review! Looking forward to getting it merged.
Message ID: ***@***.***> … |
Beyley
approved these changes
May 12, 2026
Exanite
enabled auto-merge (squash)
May 12, 2026 22:38
Exanite
disabled auto-merge
May 17, 2026 06:42
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Fixes the three broken links in the opening paragraph of the Managed Chaining docs page (
documentation/vulkan/structure-chaining/managed-chaining.md).The links used repo-relative paths (
../../src/Vulkan/...). On the rendered docs site they get rewritten to/Silk.NET/docs/src/..., which doesn't exist, so all three 404. Two of the targets were also renamed during the 3.0 work —Chain.gen.ttis nowChain.g.tt, andChain.gen.csis nowChain.g.cs.Switched the three links to absolute GitHub URLs pointing at the current paths on
main:Chain.cs— same fileChain.gen.tt→Chain.g.ttChain.gen.cs→Chain.g.csAll three new URLs return HTTP 200.
Related issues, Discord discussions, or proposals
Fixes the three links initially called out by #2566
Further Comments
Scope is intentionally limited to the three links called out in the issue (the opening paragraph). No other links in the file were changed. The unrelated CRLF normalization on
(WIP) Proposal - Axis Input Devices.mdthatgit statusshows on a fresh clone is not included in this PR.