Uh oh!
There was an error while loading. Please reload this page.
[2.0] NUKE and much-needed CI work - #353
Merged
Merged
Conversation
.NET insists on building everything again for some reason
Perksey
commented
Nov 22, 2020
MemberAuthor
@HurricanKai This is ready for review. |
HurricanKai
requested changes
Nov 22, 2020
HurricanKai
left a comment
Member
There was a problem hiding this comment.
Where is BuildTools in this?
I'm assuming this works fine in IDE.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
Perksey
commented
Nov 22, 2020
MemberAuthor
BuildTools is used in the RegenerateBindings task, called by FullPack and FullPushToNuGet. The Full tasks aren't used by CI/CD because to ensure that builds are deterministic, I only want to build from the bindings already in the repo. |
HurricanKai
approved these changes
Nov 22, 2020
Perksey added a commit
that referenced
this pull request
Mar 25, 2022
* Initial NUKE prototype * First iteration of NUKE is done * Add a test target * Attempt one at updating the CI workflow * Attempt two at CI * Update global.json * Update build.yml * Update Silk.NET.NUKE.csproj * Disable SilkTouch debug dump, checkout recursively * Only test projects that have tests in the name .NET insists on building everything again for some reason * Stop deleting packages before pushing them * Try adding Android in the loop * Stop building libsilkdroid in CI (NDK issue) * NUKE is complete * Apply suggestions from code review Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com> Co-authored-by: Kai Jellinghaus <kai.jellinghaus1@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
A short summary of this PR and what it adds/removes/fixes.
Related issues, Discord discussions, or proposals
Links go here.
Further Comments