Skip to content

This is the June 2021 Update (v2.5.0) with production-ready OpenXR - #505

Merged
Perksey merged 12 commits into
mainfrom
feature/openxr-stuff
Jun 8, 2021
Merged

This is the June 2021 Update (v2.5.0) with production-ready OpenXR#505
Perksey merged 12 commits into
mainfrom
feature/openxr-stuff

Conversation

@Perksey

@PerkseyPerksey commented Jun 4, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Will close#501
Will close#500

@PerkseyPerksey self-assigned this Jun 4, 2021
@PerkseyPerksey changed the title Add more helpers, OpenXR improvements, and an OpenXR x OpenGL demoOpenXR improvements and helpers: now production ready!Jun 6, 2021
@PerkseyPerksey changed the title OpenXR improvements and helpers: now production ready!This is the June 2021 Update (v2.5.0) with production-ready OpenXRJun 6, 2021
@Perksey
Perksey marked this pull request as ready for review June 6, 2021 20:24
@Perksey
Perksey requested a review from HurricanKai as a code ownerJune 6, 2021 20:24
@PerkseyPerksey assigned HurricanKai and unassigned PerkseyJun 6, 2021
HurricanKai
HurricanKai requested changes Jun 6, 2021
View reviewed changes

@HurricanKaiHurricanKai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know were late already, but got a couple of notes that I think need fixing.

Comment threadbuild/props/common.props Outdated
Comment threadbuild/props/common.props Outdated
Comment threadgenerator.json
Comment threadsrc/Core/Silk.NET.Core/Native/SilkMarshal.cs
Comment threadsrc/Core/Silk.NET.Core/Native/SilkMarshal.cs
Comment threadsrc/OpenXR/Silk.NET.OpenXR/Structs/GraphicsRequirements.cs
Comment threadsrc/OpenXR/Silk.NET.OpenXR/Structs/GraphicsBinding.cs
Comment threadsrc/Vulkan/Silk.NET.Vulkan/Enums/ImageLayout.gen.cs
Comment threadsrc/Windowing/Silk.NET.Windowing.Common/Structs/ViewOptions.cs
Comment threadsrc/Windowing/Silk.NET.Windowing.Common/Structs/WindowOptions.cs
@PerkseyPerksey mentioned this pull request Jun 7, 2021
Closed
HurricanKai
HurricanKai requested changes Jun 7, 2021
View reviewed changes

@HurricanKaiHurricanKai left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A project has not been included in the solution and will not be shipped! "D:\a\Silk.NET\Silk.NET\src\Vulkan\Extensions\Silk.NET.Vulkan.Extensions.FB\Silk.NET.Vulkan.Extensions.FB.csproj" if this is acceptable please add the project name (excluding the path and extension) to the AllowedExclusions array in the NUKE Build.cs file.

After that, looks good to go

@Perksey

Perksey commented Jun 7, 2021

Copy link
Copy Markdown
MemberAuthor

Lmfao well glad to know that's doing its job.

@Perksey

Perksey commented Jun 8, 2021

Copy link
Copy Markdown
MemberAuthor

@HurricanKai can you approve so we can release?

@Perksey
Perksey enabled auto-merge (squash) June 8, 2021 14:17
@Perksey
Perksey merged commit 765c172 into mainJun 8, 2021
@Perksey
Perksey deleted the feature/openxr-stuff branch June 8, 2021 15:37
Perksey added a commit that referenced this pull request Mar 25, 2022
@Perksey@HurricanKai
This is the June 2021 Update (v2.5.0) with production-ready OpenXR (#505
f6d5f61
)
* Add helper for making XrGraphicsBindingOpenGL* instances, start XR demo
* Fix OpenXR flags being 32-bit not 64-bit, "almost" working OpenXR demo
* Pushing latest demo - crosseyed is gone, replaced with weird fov thing
* Add maths helpers, is this progress I don't even know anymore
* Commit before rewrite
* Scrap the demo
* Stop us forgetting to ship bindings!
* Add missing bindings to SLN and missing typemaps, update changelog
* Update src/Core/Silk.NET.Core/Native/SilkMarshal.cs
Co-authored-by: Kai Jellinghaus <contact@kaij.tech>
* Bindings updates, fix release notes
* Update Silk.NET.sln
Co-authored-by: Kai Jellinghaus <contact@kaij.tech>
@HurricanKaiHurricanKai mentioned this pull request Feb 12, 2023
Closed
Perksey added a commit that referenced this pull request Nov 20, 2023
@Perksey@HurricanKai
This is the June 2021 Update (v2.5.0) with production-ready OpenXR (#505
fdf0ec9
)
* Add helper for making XrGraphicsBindingOpenGL* instances, start XR demo
* Fix OpenXR flags being 32-bit not 64-bit, "almost" working OpenXR demo
* Pushing latest demo - crosseyed is gone, replaced with weird fov thing
* Add maths helpers, is this progress I don't even know anymore
* Commit before rewrite
* Scrap the demo
* Stop us forgetting to ship bindings!
* Add missing bindings to SLN and missing typemaps, update changelog
* Update src/Core/Silk.NET.Core/Native/SilkMarshal.cs
Co-authored-by: Kai Jellinghaus <contact@kaij.tech>
* Bindings updates, fix release notes
* Update Silk.NET.sln
Co-authored-by: Kai Jellinghaus <contact@kaij.tech>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HurricanKaiHurricanKaiHurricanKai approved these changes

Assignees

@HurricanKaiHurricanKai

Labels

area-OpenXR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix null layer not producing nullptr in the XR extension loading system OpenXR Bindings / API cannot be used

2 participants

@Perksey@HurricanKai