Uh oh!
There was an error while loading. Please reload this page.
Adding public API to all manual projects - #779
Merged
Merged
Conversation
Perksey
marked this pull request as ready for review
January 16, 2022 16:52
Perksey
commented
Jan 16, 2022
MemberAuthor
This is ready for review. The PR mechanism hasn't been tested fully but I have enough evidence that it should in theory work, but I'll follow up with a PR immediately after if not. |
HurricanKai
requested changes
Jan 16, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
HurricanKai
approved these changes
Jan 16, 2022
Perksey
enabled auto-merge (squash)
January 16, 2022 18:02
HurricanKai
commented
Jan 16, 2022
Member
In a follow-up, consider moving all existing APIs to shipped. |
Perksey
commented
Jan 16, 2022
MemberAuthor
All APIs are in shipped to my knowledge |
Perksey added a commit
that referenced
this pull request
Mar 25, 2022
* Adding public API to all manual projects * Add `nuke shipapi`, `nuke ensureapideclared`, and `nuke declareapi` * Attempt to make GitHub talk to you * Add some logging, fix a potential regex issue * Actually pass the GitHub Token * The code was correct the first time * Fix basic logic * Try give the token more permissions? * PR target * Let's hope this PR mechanism works? Can't test until merged now! * Install workload as well * Make BuildTools exempt from public API
Closed
Perksey added a commit
that referenced
this pull request
Nov 20, 2023
* Adding public API to all manual projects * Add `nuke shipapi`, `nuke ensureapideclared`, and `nuke declareapi` * Attempt to make GitHub talk to you * Add some logging, fix a potential regex issue * Actually pass the GitHub Token * The code was correct the first time * Fix basic logic * Try give the token more permissions? * PR target * Let's hope this PR mechanism works? Can't test until merged now! * Install workload as well * Make BuildTools exempt from public API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#265