Uh oh!
There was an error while loading. Please reload this page.
Add native GLFW binary builds - #792
Merged
Merged
Conversation
Perksey
requested changes
Jan 28, 2022
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Perksey
commented
Jan 28, 2022
Member
Oh also... can you change the submodule reference to point at the latest tagged release instead of presumably the latest develop/master/whatever? The latest release SHA is Thanks! |
Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Perksey
approved these changes
Jan 28, 2022
Perksey
left a comment
Member
There was a problem hiding this comment.
Thank you so much - you are a godsend! If the PR description is alluding to you possibly doing the same for OpenAL Soft, feel free to do so!
Perksey
enabled auto-merge (squash)
January 28, 2022 13:14
roeyskoe
commented
Jan 28, 2022
ContributorAuthor
I'll look into it probably Sunday/early next week :) |
Perksey added a commit
that referenced
this pull request
Mar 25, 2022
* Start working with native builds * gh actions now? * now? * Actually get the submodules... * It now actually kinda does something * Save artifacts for testing * Not the prettiest, but may actually work * Maybe now I actually get the artifacts * Typo * What about now * Now lets put files in the right place * Maybe this is a bit nicer now * Apply suggestions from code review Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com> * Lock glfw to latest release Co-authored-by: Dylan Perks <11160611+Perksey@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Self building GLFW for Windows, Mac and Linux, including Mac arm64.
This partially resolves#727.
Related issues, Discord discussions, or proposals
https://discord.com/channels/521092042781229087/587346162802229298/936229014249562172
Further work
Currently the mac libraries cause a security warning, since they are not signed. This needs to be resolved before shipping them.
Silk is also still missing arm64 build for OpenAL, and ImGUI.NET also does not ship with arm natives.